From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753071AbcANMuD (ORCPT <rfc822;w@1wt.eu>);
	Thu, 14 Jan 2016 07:50:03 -0500
Received: from mail-wm0-f66.google.com ([74.125.82.66]:35065 "EHLO
	mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751870AbcANMuA (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 14 Jan 2016 07:50:00 -0500
Date: Thu, 14 Jan 2016 14:49:57 +0200
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        David Drysdale <drysdale@google.com>, Kees Cook <keescook@google.com>,
        Quentin Casasnovas <quentin.casasnovas@oracle.com>,
        Sasha Levin <sasha.levin@oracle.com>,
        Vegard Nossum <vegard.nossum@oracle.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Eric Dumazet <edumazet@google.com>, Tavis Ormandy <taviso@google.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        syzkaller <syzkaller@googlegroups.com>,
        Kostya Serebryany <kcc@google.com>,
        Alexander Potapenko <glider@google.com>,
        Andrey Ryabinin <ryabinin.a.a@gmail.com>
Subject: Re: [PATCH v2] kernel: add kcov code coverage
Message-ID: <20160114124957.GB28386@node.shutemov.name>
References: <1452689318-107172-1-git-send-email-dvyukov@google.com>
 <20160114090302.GA27083@node.shutemov.name>
 <CACT4Y+a1KpzS5RW4U2JY6sgpVxBGmGttYKptMe34bY4AD2ED-g@mail.gmail.com>
 <20160114092320.GB27083@node.shutemov.name>
 <CACT4Y+Z-4B_rnOmn_51a1WA6HxnVNex2ZHbeCyu-s_786wZ9gg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CACT4Y+Z-4B_rnOmn_51a1WA6HxnVNex2ZHbeCyu-s_786wZ9gg@mail.gmail.com>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jan 14, 2016 at 01:21:27PM +0100, Dmitry Vyukov wrote:
> >> Alternatively, you can try to bulk disable instrumentation of
> >> everything related to boot process (by adding KCOV_INSTRUMENT := n to
> >> the Makefile). Most likely it is due to instrumentation. If it helps,
> >> try to bisect the the guilty files.
> >
> > Okay, I'll try.
> 
> 
> I've tried with exactly your gcc revision and your config and VM boots fine...
> 
> For me it prints 4 CPUs:
> [    0.193348] smpboot: Total of 4 processors activated
> so it is probably fine :)
> 
> I am almost sure that the root cause is kcov instrumentation is some
> inappropriate place. I've fixed such symptoms several times by
> disabling instrumentation in various places.

Okay, I found it. The patch below helps.

But I wounder how safe this thing is. :-/

Looks like -fsanitize-coverage=trace-pc doesn't play well when we change
calling convention for the compilation unit, as we do for hweight.o.
See CONFIG_ARCH_HWEIGHT_CFLAGS.

What else should we expect from GCC in this mode?

diff --git a/lib/Makefile b/lib/Makefile
index 58043870dbd2..56171482f99f 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -15,6 +15,7 @@ KCOV_INSTRUMENT_rbtree.o := n
 KCOV_INSTRUMENT_list_debug.o := n
 KCOV_INSTRUMENT_debugobjects.o := n
 KCOV_INSTRUMENT_dynamic_debug.o := n
+KCOV_INSTRUMENT_hweight.o := n
 
 lib-y := ctype.o string.o vsprintf.o cmdline.o \
         rbtree.o radix-tree.o dump_stack.o timerqueue.o\
-- 
 Kirill A. Shutemov