From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753283AbcANOHu (ORCPT ); Thu, 14 Jan 2016 09:07:50 -0500 Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:57140 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752515AbcANOHs (ORCPT ); Thu, 14 Jan 2016 09:07:48 -0500 Date: Thu, 14 Jan 2016 14:07:31 +0000 From: One Thousand Gnomes To: Andy Lutomirski Cc: Pali =?UTF-8?B?Um9ow6Fy?= , Jean Delvare , Andy Lutomirski , platform-driver-x86@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] dell-wmi: Stop storing pointers to DMI tables Message-ID: <20160114140731.0b324e92@lxorguk.ukuu.org.uk> In-Reply-To: References: <119170b95d373bc943eb4f16818239bac9fa6c59.1451832667.git.luto@kernel.org> <20160112142538.GB11560@pali> Organization: Intel Corporation X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.29; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Jean, am I right that drivers must not store pointers to DMI tables > that they find through dmi_walk? Is there any alternative interface > that could be used to get a longer-lived pointer to DMI tables, or > should drivers just parse them and copy out any info needed from the > dmi_walk callback? The easiest long term solution might be to just map the dmi buffer once and keep it. It's not that huge so it's not a big address space hog. Alan