From: Jean Delvare <jdelvare@suse.de>
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Cc: "Andy Lutomirski" <luto@amacapital.net>,
"Pali Rohár" <pali.rohar@gmail.com>,
"Jean Delvare" <jdelvare@suse.com>,
"Andy Lutomirski" <luto@kernel.org>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dell-wmi: Stop storing pointers to DMI tables
Date: Thu, 14 Jan 2016 21:16:12 +0100 [thread overview]
Message-ID: <20160114211612.5c253e32@endymion.delvare> (raw)
In-Reply-To: <20160114140731.0b324e92@lxorguk.ukuu.org.uk>
Hi Alan,
On Thu, 14 Jan 2016 14:07:31 +0000, One Thousand Gnomes wrote:
> > Jean, am I right that drivers must not store pointers to DMI tables
> > that they find through dmi_walk? Is there any alternative interface
> > that could be used to get a longer-lived pointer to DMI tables, or
> > should drivers just parse them and copy out any info needed from the
> > dmi_walk callback?
>
> The easiest long term solution might be to just map the dmi buffer once
> and keep it. It's not that huge so it's not a big address space hog.
Please note that SMBIOS specification version 3.0 allows for 32-bit
length for DMI tables, suggesting that 64k tables were not large enough
for everyone.
Just saying. I have no strong opinion on the matter.
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2016-01-14 20:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-03 14:52 Andy Lutomirski
2016-01-11 21:58 ` Andy Lutomirski
2016-01-12 14:25 ` Pali Rohár
2016-01-13 22:28 ` Andy Lutomirski
2016-01-14 9:52 ` Michał Kępień
2016-01-15 13:23 ` Jean Delvare
2016-01-14 14:07 ` One Thousand Gnomes
2016-01-14 20:16 ` Jean Delvare [this message]
2016-01-15 13:27 ` Jean Delvare
2016-01-15 16:27 ` Andy Lutomirski
2016-01-15 17:53 ` Jean Delvare
2016-01-15 20:00 ` Andy Lutomirski
2016-01-19 9:12 ` Jean Delvare
2016-01-14 10:29 ` Michał Kępień
2016-01-18 15:44 ` Jean Delvare
2016-01-18 18:09 ` Andy Lutomirski
2016-01-18 18:19 ` Andy Lutomirski
2016-01-19 9:19 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160114211612.5c253e32@endymion.delvare \
--to=jdelvare@suse.de \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=jdelvare@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®