From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753941AbcAOTry (ORCPT ); Fri, 15 Jan 2016 14:47:54 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:32827 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751281AbcAOTrw (ORCPT ); Fri, 15 Jan 2016 14:47:52 -0500 Date: Fri, 15 Jan 2016 14:47:49 -0500 (EST) Message-Id: <20160115.144749.588820079930764465.davem@davemloft.net> To: nathan.sullivan@ni.com Cc: nicolas.ferre@atmel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: macb: clear interrupts when disabling them From: David Miller In-Reply-To: <1452799647-1426-1-git-send-email-nathan.sullivan@ni.com> References: <1452799647-1426-1-git-send-email-nathan.sullivan@ni.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 15 Jan 2016 11:47:51 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nathan Sullivan Date: Thu, 14 Jan 2016 13:27:27 -0600 > Disabling interrupts with the IDR register does not stop the macb hardware > from asserting its interrupt line if there are interrupts pending. Always > clear the interrupts using ISR, and be sure to write it on hardware that > is not read-to-clear, like Zynq. Not doing so will cause interrupts when > the driver doesn't expect them. > > Signed-off-by: Nathan Sullivan Applied, thanks.