From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753882AbcAOTzH (ORCPT <rfc822;w@1wt.eu>);
	Fri, 15 Jan 2016 14:55:07 -0500
Received: from shards.monkeyblade.net ([149.20.54.216]:32865 "EHLO
	shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752274AbcAOTzE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 15 Jan 2016 14:55:04 -0500
Date: Fri, 15 Jan 2016 14:55:02 -0500 (EST)
Message-Id: <20160115.145502.1019508793273660216.davem@davemloft.net>
To: t.remmet@phytec.de
Cc: netdev@vger.kernel.org, f.fainelli@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: phy: smsc: Fix disabling energy detect mode
From: David Miller <davem@davemloft.net>
In-Reply-To: <1452849633-26877-1-git-send-email-t.remmet@phytec.de>
References: <1452849633-26877-1-git-send-email-t.remmet@phytec.de>
X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 15 Jan 2016 11:55:03 -0800 (PST)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Teresa Remmet <t.remmet@phytec.de>
Date: Fri, 15 Jan 2016 10:20:33 +0100

> @@ -110,10 +105,11 @@ static int lan911x_config_init(struct phy_device *phydev)
>   */
>  static int lan87xx_read_status(struct phy_device *phydev)
>  {
> +	bool *energy_enable = phydev->priv;
>  	int err = genphy_read_status(phydev);
>  	int i;

Please order local variable declarations from longest to shortest line.

> +static int smsc_phy_probe(struct phy_device *phydev)
> +{
> +	struct device *dev = &phydev->mdio.dev;
> +	bool *energy_enable;
> +	int __maybe_unused len;
> +	struct device_node *of_node __maybe_unused = dev->of_node;

Likewise.