From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754859AbcAOUMR (ORCPT ); Fri, 15 Jan 2016 15:12:17 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:32949 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753306AbcAOUMP (ORCPT ); Fri, 15 Jan 2016 15:12:15 -0500 Date: Fri, 15 Jan 2016 15:12:13 -0500 (EST) Message-Id: <20160115.151213.2258553264727846515.davem@davemloft.net> To: geert@linux-m68k.org Cc: vyasevich@gmail.com, nhorman@tuxdriver.com, lucien.xin@gmail.com, linux-sctp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: sctp: Move sequence start handling into sctp_transport_get_idx() From: David Miller In-Reply-To: <1452865471-32509-1-git-send-email-geert@linux-m68k.org> References: <1452865471-32509-1-git-send-email-geert@linux-m68k.org> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-7 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 15 Jan 2016 12:12:15 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u0FKCMYL031929 From: Geert Uytterhoeven Date: Fri, 15 Jan 2016 14:44:31 +0100 > net/sctp/proc.c: In function ¡sctp_transport_get_idx¢: > net/sctp/proc.c:313: warning: ¡obj¢ may be used uninitialized in this function > > This is currently a false positive, as all callers check for a zero > offset first, and handle this case in the exact same way. > > Move the check and handling into sctp_transport_get_idx() to kill the > compiler warning, and avoid future bugs. > > Signed-off-by: Geert Uytterhoeven Applied, thanks Geert.