From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757428AbcAOKPJ (ORCPT ); Fri, 15 Jan 2016 05:15:09 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33257 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753835AbcAOKPE (ORCPT ); Fri, 15 Jan 2016 05:15:04 -0500 Date: Fri, 15 Jan 2016 11:14:59 +0100 From: Ingo Molnar To: One Thousand Gnomes Cc: Keerthy , Keerthy , linux-kernel@vger.kernel.org, edubezval@gmail.com, grygorii.strashko@ti.com, nm@ti.com, linux-pm@vger.kernel.org, linux-omap@vger.kernel.org, joel@jms.id.au, akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org, peterz@infradead.org, dyoung@redhat.com, josh@joshtriplett.org, mpe@ellerman.id.au, Thomas Gleixner , Peter Zijlstra Subject: Re: [PATCH v2] reboot: Backup orderly_poweroff Message-ID: <20160115101459.GB23349@gmail.com> References: <1452688405-15087-1-git-send-email-j-keerthy@ti.com> <20160114090520.GA4351@gmail.com> <569767EC.2010704@ti.com> <20160114100913.GB15857@gmail.com> <56977BA7.702@ti.com> <20160114112354.GA17869@gmail.com> <20160114132527.575e0f20@lxorguk.ukuu.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160114132527.575e0f20@lxorguk.ukuu.org.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * One Thousand Gnomes wrote: > > If kernel_power_off() is called then the system should power off. No ifs and > > whens. > > Even if it doesn't the watchdog should kill it. > > That is broken on some platforms on the watchdog side as the > watchdog shuts down during our power off callbacks - because the system > firmware is too stupid to reset the watchdog as it powers back up (so > keeps rebooting). > > If you watchdog and firmware function properly you shouldn't even have to > care if you crash during the kernel power off. That's a good point as well - if the system is 'stuck' for some notion of stuck, then watchdog drivers can help. Here it's unclear whether user-space even called the sys_reboot() system call. Thanks, Ingo