From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756256AbcAOLuH (ORCPT ); Fri, 15 Jan 2016 06:50:07 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:56064 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754640AbcAOLuF (ORCPT ); Fri, 15 Jan 2016 06:50:05 -0500 Date: Fri, 15 Jan 2016 11:49:46 +0000 From: Mark Brown To: Peter Zijlstra Cc: Stefan Agner , festevam@gmail.com, mingo@redhat.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Message-ID: <20160115114946.GV6588@sirena.org.uk> References: <20160115094541.GH3421@worktop> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="R6pG8OF89Zv1WQ+4" Content-Disposition: inline In-Reply-To: <20160115094541.GH3421@worktop> X-Cookie: APL hackers do it in the quad. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: Lockdep warning when using REGCACHE_RBTREE X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --R6pG8OF89Zv1WQ+4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jan 15, 2016 at 10:45:41AM +0100, Peter Zijlstra wrote: > So _regmap_write() does: map->lock(map->lock_arg) > Which isn't very enlightening, since that can be a mutex or a spinlock, > the above strongly suggests spinlock though. > Looking at __regmap_init(), this seems to depend on: > (bus && bus->fast_io) || config->fast_io > now, afaict, regmap_mmio is used in this case, which has .fast_io = > true. > So yeah, fail. Indeed, that'd do it. It hadn't occurred to me that someone would be using MMIO with an rbtree cache. --R6pG8OF89Zv1WQ+4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWmNzZAAoJECTWi3JdVIfQ73QH/RhD3lEdX/7aY8xlwKt1Qzoy Mk4TQpSDQ5y9H1R2frvyUThhm19T/a9kWZsBBMGc3S3M9ORo5GrBKlmFiFouysoQ 2zrKg4/cubMpN3u9Dq5nQ0JhRPWmAxN5TR6lCW25IryiwAIzkrg2REVZZni6G9dC LNCkJnA4X4uK2PNN2+L6XaKRMK5a+pCWe7NJgSSzhCRQFk/UT1/Md+CDaPlpfg1h cM7lpVmUuRJZg0fQMGBHDZj70ZIvMCsmCqNkOupctxSjwqSgxWJLRuWldYUjhXFn H3gKdlvTwJ+yM646KNcU9zj6DaXGwZV/zrBTdO458HWUKzZJ0Dgpq8BK6mTgkJ4= =WKoG -----END PGP SIGNATURE----- --R6pG8OF89Zv1WQ+4--