From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752873AbcAOSBy (ORCPT ); Fri, 15 Jan 2016 13:01:54 -0500 Received: from mail-pa0-f47.google.com ([209.85.220.47]:33691 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751281AbcAOSBw (ORCPT ); Fri, 15 Jan 2016 13:01:52 -0500 Date: Fri, 15 Jan 2016 10:01:49 -0800 From: Brian Norris To: Geert Uytterhoeven Cc: David Woodhouse , Matthias Brugger , Bayi Cheng , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: mtk-nor: Drop bogus __init from mtk_nor_init() Message-ID: <20160115180149.GT109450@google.com> References: <1452865589-555-1-git-send-email-geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452865589-555-1-git-send-email-geert@linux-m68k.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 15, 2016 at 02:46:29PM +0100, Geert Uytterhoeven wrote: > WARNING: drivers/mtd/spi-nor/mtk-quadspi.o(.text+0x77e): Section mismatch in reference from the function mtk_nor_drv_probe() to the function .init.text:mtk_nor_init() > The function mtk_nor_drv_probe() references > the function __init mtk_nor_init(). > This is often because mtk_nor_drv_probe lacks a __init > annotation or the annotation of mtk_nor_init is wrong. > > Drop the bogus __init from mtk_nor_init() to kill this warning. > > Signed-off-by: Geert Uytterhoeven > --- > Presumably this went unnoticed because some versions of gcc inline > mtk_nor_init()? Pushed to l2-mtd.git. Thanks!