From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754766AbcAOTJm (ORCPT <rfc822;w@1wt.eu>);
	Fri, 15 Jan 2016 14:09:42 -0500
Received: from zeniv.linux.org.uk ([195.92.253.2]:44517 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750955AbcAOTJl (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 15 Jan 2016 14:09:41 -0500
Date: Fri, 15 Jan 2016 19:09:39 +0000
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Borislav Petkov <bp@alien8.de>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] amdkfd: Copy from the proper user command pointer
Message-ID: <20160115190939.GE17997@ZenIV.linux.org.uk>
References: <1452882404-24627-1-git-send-email-bp@alien8.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1452882404-24627-1-git-send-email-bp@alien8.de>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 15, 2016 at 07:26:44PM +0100, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
> 
> 8f1d57c17248 ("amdkfd: don't open-code memdup_user()") mistakenly uses
> an uninitialized local pointer, gcc complains:
> 
>   drivers/gpu/drm/amd/amdkfd/kfd_chardev.c: In function ‘kfd_ioctl_dbg_address_watch’:
>   drivers/gpu/drm/amd/amdkfd/kfd_chardev.c:562:12: warning: ‘args_buff’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>     args_buff = memdup_user(args_buff,
>                 ^
> 
> Fix it.

Mea culpa...  Applied, and I wonder how the hell I'd missed that..