From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754448AbcAOVAt (ORCPT ); Fri, 15 Jan 2016 16:00:49 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:45039 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752733AbcAOVAs (ORCPT ); Fri, 15 Jan 2016 16:00:48 -0500 Date: Fri, 15 Jan 2016 21:00:46 +0000 From: Al Viro To: Linus Torvalds Cc: Linux Kernel Mailing List , linux-fsdevel Subject: Re: [git pull] vfs.git regression fix Message-ID: <20160115210046.GG17997@ZenIV.linux.org.uk> References: <20160115201810.GF17997@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 15, 2016 at 12:41:06PM -0800, Linus Torvalds wrote: > Al, > _please_ learn to be more careful about your pull requests. > > This one is garbage. > > Why? > > You ask me to pull from the wrong source. You ask me to pull from > > git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs > > but that is some random state from January 2014. Two years ago. > > What you actually *meant* was apparently the "for-linus" branch, since > that matches the shortlog and diffstat. But that's not what your pull > request asked me to pull. > > This is not the first time. You seem to either use buggy scripts, or > do this (wrong) by hand. Please fix whatever it is, so that I don't > have to go look or guess after I notice that I pulled crap. Buggy scripts, actually. The thing that generates them takes a branch name as argument; turns out that it (pretty much by accident) treats the missing argument as HEAD. Which tends to give reasonable diffstat and shortlog, so I hadn't spotted the missing check until now. Fixed. BTW, is there any better way to get the current branch name than git branch |sed -ne '/\* /s///p'?