From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756572AbcARTNJ (ORCPT ); Mon, 18 Jan 2016 14:13:09 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:41988 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756558AbcARTNH (ORCPT ); Mon, 18 Jan 2016 14:13:07 -0500 Date: Mon, 18 Jan 2016 14:13:05 -0500 (EST) Message-Id: <20160118.141305.2278027302620439950.davem@davemloft.net> To: paul.gortmaker@windriver.com Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org Subject: Re: [PATCH] drivers/ide: make ide-scan-pci.c driver explicitly non-modular From: David Miller In-Reply-To: <1449697551-16096-1-git-send-email-paul.gortmaker@windriver.com> References: <1449697551-16096-1-git-send-email-paul.gortmaker@windriver.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 18 Jan 2016 11:13:06 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Paul Gortmaker Date: Wed, 9 Dec 2015 16:45:51 -0500 > The Kconfig for this support is currently: > > config IDEPCI_PCIBUS_ORDER > bool "Probe IDE PCI devices in the PCI bus order (DEPRECATED)" > > ...meaning that it currently is not being built as a module by anyone. > Lets change the initcall to be the equivalent device_initcall, so that > when reading the driver code, there is no doubt it is builtin-only. > > Unlike other similar changes, we leave the module.h header to be > included since this code interacts with other drivers and needs to > know what a struct module is. > > Cc: "David S. Miller" > Cc: linux-ide@vger.kernel.org > Signed-off-by: Paul Gortmaker Applied.