From: Peter Zijlstra <peterz@infradead.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Linux PM list <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH 1/2] sched / idle: Drop default_idle_call() fallback from call_cpuidle()
Date: Mon, 18 Jan 2016 15:36:28 +0100 [thread overview]
Message-ID: <20160118143628.GR6357@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <2393290.LAksQzHH19@vostro.rjw.lan>
On Sat, Jan 16, 2016 at 12:54:53AM +0100, Rafael J. Wysocki wrote:
> This eliminates one branch from the idle loop and makes the governors
> and find_deepest_state() handle the case when all states have been
> disabled from sysfs consistently.
> Index: linux-pm/kernel/sched/idle.c
> ===================================================================
> --- linux-pm.orig/kernel/sched/idle.c
> +++ linux-pm/kernel/sched/idle.c
> @@ -97,12 +97,6 @@ void default_idle_call(void)
> static int call_cpuidle(struct cpuidle_driver *drv, struct cpuidle_device *dev,
> int next_state)
> {
> - /* Fall back to the default arch idle method on errors. */
> - if (next_state < 0) {
> - default_idle_call();
> - return next_state;
> - }
> -
> /*
> * The idle task must be scheduled, it is pointless to go to idle, just
> * update no idle residency and return.
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
next prev parent reply other threads:[~2016-01-18 14:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 23:53 [PATCH 0/2] cpuidle optimizations (on top of linux-next) Rafael J. Wysocki
2016-01-15 23:54 ` [PATCH 1/2] sched / idle: Drop default_idle_call() fallback from call_cpuidle() Rafael J. Wysocki
2016-01-18 14:36 ` Peter Zijlstra [this message]
2016-01-15 23:56 ` [PATCH 2/2] cpuidle: menu: Avoid pointless checks in menu_select() Rafael J. Wysocki
2016-01-18 22:51 ` [Resend][PATCH " Rafael J. Wysocki
2016-01-18 13:45 ` [PATCH 0/2] cpuidle optimizations (on top of linux-next) Sudeep Holla
2016-01-19 7:28 ` Ingo Molnar
2016-01-19 13:14 ` Rafael J. Wysocki
2016-01-19 13:28 ` Ingo Molnar
2016-01-19 13:50 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160118143628.GR6357@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome