From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755538AbcARPZM (ORCPT ); Mon, 18 Jan 2016 10:25:12 -0500 Received: from helcar.hengli.com.au ([209.40.204.226]:38453 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754898AbcARPZI (ORCPT ); Mon, 18 Jan 2016 10:25:08 -0500 Date: Mon, 18 Jan 2016 23:24:57 +0800 From: Herbert Xu To: Arnd Bergmann Cc: Dan Streetman , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: lib: sw842: select crc32 Message-ID: <20160118152457.GD717@gondor.apana.org.au> References: <4168537.6I1FVkp3DA@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4168537.6I1FVkp3DA@wuerfel> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 13, 2016 at 11:24:02PM +0100, Arnd Bergmann wrote: > The sw842 library code was merged in linux-4.1 and causes a very rare randconfig > failure when CONFIG_CRC32 is not set: > > lib/built-in.o: In function `sw842_compress': > oid_registry.c:(.text+0x12ddc): undefined reference to `crc32_be' > lib/built-in.o: In function `sw842_decompress': > oid_registry.c:(.text+0x137e4): undefined reference to `crc32_be' > > This adds an explict 'select CRC32' statement, similar to what the other users > of the crc32 code have. In practice, CRC32 is always enabled anyway because > over 100 other symbols select it. > > Signed-off-by: Arnd Bergmann > Fixes: 2da572c959dd ("lib: add software 842 compression/decompression") Patch applied. Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt