From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755878AbcARQtg (ORCPT ); Mon, 18 Jan 2016 11:49:36 -0500 Received: from mail-wm0-f52.google.com ([74.125.82.52]:35530 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755597AbcARQte (ORCPT ); Mon, 18 Jan 2016 11:49:34 -0500 Date: Mon, 18 Jan 2016 17:49:37 +0100 From: Daniel Vetter To: Geliang Tang Cc: Daniel Vetter , Jani Nikula , David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH 1/5 v2] drm/i915: use hlist_for_each_entry Message-ID: <20160118164937.GK19130@phenom.ffwll.local> Mail-Followup-To: Geliang Tang , Daniel Vetter , Jani Nikula , David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20160113151255.GH3541@nuc-i3427.alporthouse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 4.3.0-1-amd64 User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 18, 2016 at 11:54:20PM +0800, Geliang Tang wrote: > Use hlist_for_each_entry() instead of hlist_for_each() to simplify > the code. > > Signed-off-by: Geliang Tang > --- > Changes in v2: > - Keep head = &eb->buckets[handle & eb->and] Queued for -next, thanks for the patch. -Daniel > --- > drivers/gpu/drm/i915/i915_gem_execbuffer.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c > index dccb517..7dc95a7 100644 > --- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c > +++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c > @@ -193,13 +193,10 @@ static struct i915_vma *eb_get_vma(struct eb_vmas *eb, unsigned long handle) > return eb->lut[handle]; > } else { > struct hlist_head *head; > - struct hlist_node *node; > + struct i915_vma *vma; > > head = &eb->buckets[handle & eb->and]; > - hlist_for_each(node, head) { > - struct i915_vma *vma; > - > - vma = hlist_entry(node, struct i915_vma, exec_node); > + hlist_for_each_entry(vma, head, exec_node) { > if (vma->exec_handle == handle) > return vma; > } > -- > 2.5.0 > > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch