From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932460AbcARWO6 (ORCPT ); Mon, 18 Jan 2016 17:14:58 -0500 Received: from gum.cmpxchg.org ([85.214.110.215]:53382 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932180AbcARWO4 (ORCPT ); Mon, 18 Jan 2016 17:14:56 -0500 Date: Mon, 18 Jan 2016 17:14:27 -0500 From: Johannes Weiner To: Maninder Singh Cc: mhocko@kernel.org, vdavydov@virtuozzo.com, akpm@linux-foundation.org, mgorman@techsingularity.net, vbabka@suse.cz, baiyaowei@cmss.chinamobile.com, dan.j.williams@intel.com, tj@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, ajeet.y@samsung.com, pankaj.m@samsung.com, Vaneet Narang Subject: Re: [PATCH 1/1] mmzone: code cleanup for LRU stats. Message-ID: <20160118221427.GA8657@cmpxchg.org> References: <1453101492-37125-1-git-send-email-maninder1.s@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453101492-37125-1-git-send-email-maninder1.s@samsung.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 18, 2016 at 12:48:12PM +0530, Maninder Singh wrote: > Replacing hardcoded values with enum lru_stats for LRU stats. > > Signed-off-by: Maninder Singh > Signed-off-by: Vaneet Narang I don't think the code is hard to understand, it always says 'anon' or 'file' or similar for every context where it's important to understand what the magic array index means. And this patch makes the lines too long and unwieldy.