From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932948AbcASTbp (ORCPT ); Tue, 19 Jan 2016 14:31:45 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:54190 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932321AbcASTbg (ORCPT ); Tue, 19 Jan 2016 14:31:36 -0500 Date: Tue, 19 Jan 2016 14:31:34 -0500 (EST) Message-Id: <20160119.143134.622696308505132405.davem@davemloft.net> To: andrew@lunn.ch Cc: t.remmet@phytec.de, netdev@vger.kernel.org, f.fainelli@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net: phy: smsc: Fix disabling energy detect mode From: David Miller In-Reply-To: <20160119152503.GK6554@lunn.ch> References: <1453190199-22269-1-git-send-email-t.remmet@phytec.de> <20160119152503.GK6554@lunn.ch> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 19 Jan 2016 11:31:36 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andrew Lunn Date: Tue, 19 Jan 2016 16:25:03 +0100 >> +struct smsc_phy_priv { >> + bool energy_enable:1; >> +}; > > Time to show my ignorance of bitfields. Since this is a bool, does the > :1 actually do anything? Even if does something, saving space for a datastructure like this makes no sense. There are no adjacent bit fields to share the space with. Just use plain 'bool'. >> +static int smsc_phy_probe(struct phy_device *phydev) >> +{ >> + struct device *dev = &phydev->mdio.dev; >> + struct device_node *of_node __maybe_unused = dev->of_node; >> + struct smsc_phy_priv *priv; >> + int __maybe_unused len; >> + >> + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); >> + if (!priv) >> + return -ENOMEM; >> + >> + if (of_find_property(of_node, "smsc,disable-energy-detect", &len)) >> + priv->energy_enable = false; > > Here you set it to false. Where does it get set to true? > > Also, of_property_read_bool() would be a better call than of_find_property. Yeah this looks broken to me too.