From: Peter Zijlstra <peterz@infradead.org>
To: kan.liang@intel.com
Cc: acme@kernel.org, eranian@google.com, ak@linux.intel.com,
jolsa@kernel.org, namhyung@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/8] perf: Add PERF_SAMPLE_PHYS_ADDR
Date: Tue, 19 Jan 2016 17:30:20 +0100 [thread overview]
Message-ID: <20160119163020.GJ6344@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1452173440-10697-1-git-send-email-kan.liang@intel.com>
On Thu, Jan 07, 2016 at 08:30:33AM -0500, kan.liang@intel.com wrote:
> From: Kan Liang <kan.liang@intel.com>
>
> For understanding how the workload maps to memory channels and hardware
> behavior, it's useful to collect address maps with physical addresses.
> This is not intended for detecting page sharing (which can be already
> done using the mmap inode), but for lower level hardware behavior
> studies.
This patch set completely lacks any useful example for why we should
entertain this.
> @@ -8269,6 +8275,11 @@ SYSCALL_DEFINE5(perf_event_open,
> return -EINVAL;
> }
>
> + /* Only privileged users can get kernel addresses */
> + if ((attr.sample_type & PERF_SAMPLE_PHYS_ADDR) &&
> + !capable(CAP_SYS_ADMIN))
> + return -EACCES;
> +
should that not also include a perf_paranoid_kernel() test?
prev parent reply other threads:[~2016-01-19 16:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 13:30 kan.liang
2016-01-07 13:30 ` [PATCH V2 2/8] perf tools: add option to record sample physical address kan.liang
2016-01-07 13:30 ` [PATCH V2 3/8] perf tools: add sort option phys_daddr kan.liang
2016-01-07 13:30 ` [PATCH V2 4/8] perf mem: add option phys-data to record physical address kan.liang
2016-01-07 13:30 ` [PATCH V2 5/8] perf mem: report physical addresses kan.liang
2016-01-07 13:30 ` [PATCH V2 6/8] perf mem: dump " kan.liang
2016-01-07 13:30 ` [PATCH V2 7/8] perf script: support physical addresses in script kan.liang
2016-01-07 13:30 ` [PATCH V2 8/8] perf test: add test case for PERF_SAMPLE_PHYS_ADDR kan.liang
2016-01-07 21:08 ` [PATCH V2 1/8] perf: Add PERF_SAMPLE_PHYS_ADDR kbuild test robot
2016-01-07 21:22 ` kbuild test robot
2016-01-19 16:30 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160119163020.GJ6344@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome