From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756979AbcASRW1 (ORCPT ); Tue, 19 Jan 2016 12:22:27 -0500 Received: from mail-pa0-f66.google.com ([209.85.220.66]:33567 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756174AbcASRWT (ORCPT ); Tue, 19 Jan 2016 12:22:19 -0500 Date: Tue, 19 Jan 2016 12:22:17 -0500 From: Tejun Heo To: Sergei Shtylyov Cc: Andy Lutomirski , linux-ide@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] libata: disable forced PORTS_IMPL for >= AHCI 1.3 Message-ID: <20160119172217.GQ3520@mtj.duckdns.org> References: <20160114223732.GG3520@mtj.duckdns.org> <20160115201305.GN3520@mtj.duckdns.org> <569A16E1.7010708@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <569A16E1.7010708@cogentembedded.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 16, 2016 at 01:09:37PM +0300, Sergei Shtylyov wrote: > >+ /* fabricate port_map from cap.nr_ports for < AHCI 1.3 */ > >+ if (!port_map && (!(vers >> 16) || > >+ ((vers >> 16) == 1 && (vers & 0xFFFF) < 0x300))) { > > Hm, won't just (vers < 0x1300) just work? lol, indeed. Lemme update the patch. Thanks. -- tejun