From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934271AbcATJL0 (ORCPT ); Wed, 20 Jan 2016 04:11:26 -0500 Received: from mx2.suse.de ([195.135.220.15]:33624 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934135AbcATJJh (ORCPT ); Wed, 20 Jan 2016 04:09:37 -0500 Date: Wed, 20 Jan 2016 10:09:31 +0100 From: Johannes Thumshirn To: Wenbo Wang Cc: keith.busch@intel.com, axboe@fb.com, Wenbo Wang , wenwei.tao@memblaze.com, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH] NVMe: init nvme queue before enabling irq Message-ID: <20160120090931.GO2742@c203.arch.suse.de> References: <1453265860-31080-1-git-send-email-mail_weber_wang@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1453265860-31080-1-git-send-email-mail_weber_wang@163.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 19, 2016 at 11:57:40PM -0500, Wenbo Wang wrote: > During reset process, the nvme_dev->bar (ioremapped) may change, > so nvmeq->q_db shall be also updated by nvme_init_queue(). > > Currently nvmeq irq is enabled before queue init, so a spurious > interrupt triggered nvme_process_cq may access nvmeq->q_db just > before it is updated, this could cause kernel panic. If it can cause a kernel panic shouldn't it go through stable then as well? > > Signed-off-by: Wenbo Wang > Reviewed-by: Wenwei Tao > --- > drivers/nvme/host/pci.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c > index f5c0e26..df55f28 100644 > --- a/drivers/nvme/host/pci.c > +++ b/drivers/nvme/host/pci.c > @@ -1590,11 +1590,17 @@ static int nvme_create_queue(struct nvme_queue *nvmeq, int qid) > if (result < 0) > goto release_cq; > > + /* > + * Init queue door bell ioremap address before enabling irq, if not, > + * a spurious interrupt triggered nvme_process_cq may access invalid > + * address > + */ > + nvme_init_queue(nvmeq, qid); > + > result = queue_request_irq(dev, nvmeq, nvmeq->irqname); > if (result < 0) > goto release_sq; > > - nvme_init_queue(nvmeq, qid); > return result; > > release_sq: > @@ -1789,6 +1795,8 @@ static int nvme_configure_admin_queue(struct nvme_dev *dev) > if (result) > goto free_nvmeq; > > + nvme_init_queue(nvmeq, 0); > + > nvmeq->cq_vector = 0; > result = queue_request_irq(dev, nvmeq, nvmeq->irqname); > if (result) { > @@ -3164,7 +3172,6 @@ static void nvme_probe_work(struct work_struct *work) > goto disable; > } > > - nvme_init_queue(dev->queues[0], 0); > result = nvme_alloc_admin_tags(dev); > if (result) > goto disable; > -- > 1.8.3.1 > > > > _______________________________________________ > Linux-nvme mailing list > Linux-nvme@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-nvme Other than that Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850