From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934655AbcATKWs (ORCPT ); Wed, 20 Jan 2016 05:22:48 -0500 Received: from mx2.suse.de ([195.135.220.15]:40143 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934473AbcATKWi (ORCPT ); Wed, 20 Jan 2016 05:22:38 -0500 Date: Wed, 20 Jan 2016 11:22:28 +0100 From: Johannes Thumshirn To: Sagi Grimberg Cc: Wenbo Wang , Wenbo Wang , "keith.busch@intel.com" , "axboe@fb.com" , "Wenwei.Tao" , "linux-kernel@vger.kernel.org" , "linux-nvme@lists.infradead.org" Subject: Re: [PATCH] NVMe: init nvme queue before enabling irq Message-ID: <20160120102228.GP2742@c203.arch.suse.de> References: <1453265860-31080-1-git-send-email-mail_weber_wang@163.com> <20160120090931.GO2742@c203.arch.suse.de> <569F59B1.3040207@dev.mellanox.co.il> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <569F59B1.3040207@dev.mellanox.co.il> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 20, 2016 at 11:56:01AM +0200, Sagi Grimberg wrote: > > >>If it can cause a kernel panic shouldn't it go through stable then as well? > > > >Sorry, not quite understand this comment. > >The "reset process" is the nvme device reset process (performed by nvme_reset_work()) triggered by device fail condition. > >During normal boot up, nvmeq door bell is initialized in nvme_alloc_queue() which happens before enabling irq, so there is no error. > >During nvme device reset process, nvme_alloc_queue() is skipped and the race condition exists. > > I think what Johannes meant was that this patch should include a > "CC: stable@vger.kernel.org" tag. > Exactly. This makes work for us distribution people a lot easier (i.e. we do not have to manually scan all commits and decide if we need to backport a patch or not) Thanks > _______________________________________________ > Linux-nvme mailing list > Linux-nvme@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-nvme -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850