From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760070AbcAUSp7 (ORCPT ); Thu, 21 Jan 2016 13:45:59 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:46106 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759617AbcAUSp4 (ORCPT ); Thu, 21 Jan 2016 13:45:56 -0500 Date: Thu, 21 Jan 2016 10:45:55 -0800 (PST) Message-Id: <20160121.104555.194909626689511824.davem@davemloft.net> To: sudipm.mukherjee@gmail.com Cc: samuel@sortiz.org, realmz6@gmail.com, linux-kernel@vger.kernel.org, kernel-testers@vger.kernel.org, netdev@vger.kernel.org, adi-buildroot-devel@lists.sourceforge.net Subject: Re: [PATCH] net/irda: bfin_sir: remove duplicate defines From: David Miller In-Reply-To: <1453353151-4622-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1453353151-4622-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 21 Jan 2016 10:45:56 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sudip Mukherjee Date: Thu, 21 Jan 2016 10:42:31 +0530 > The defconfig build of blackfin is failing with the error: > > arch/blackfin/include/asm/bfin_serial.h:269:0: warning: "port_membase" redefined > drivers/net/irda/bfin_sir.h:85:0: note: this is the location of the previous definition > arch/blackfin/include/asm/bfin_serial.h:382:0: warning: "get_lsr_cache" redefined > drivers/net/irda/bfin_sir.h:86:0: note: this is the location of the previous definition > arch/blackfin/include/asm/bfin_serial.h:383:0: warning: "put_lsr_cache" redefined > drivers/net/irda/bfin_sir.h:87:0: note: this is the location of the previous definition > > port_membase, get_lsr_cache, put_lsr_cache are already defined in the > architecture files, no need to define them again in the driver. > > Signed-off-by: Sudip Mukherjee Applied, thank you.