From: Mark Brown <broonie@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Andy Gross <andy.gross@linaro.org>,
linux-spi@vger.kernel.org, David Brown <david.brown@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: qup: provide proper bus numbers
Date: Thu, 21 Jan 2016 18:38:10 +0000 [thread overview]
Message-ID: <20160121183810.GN6588@sirena.org.uk> (raw)
In-Reply-To: <1453401227-27135-1-git-send-email-srinivas.kandagatla@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 677 bytes --]
On Thu, Jan 21, 2016 at 06:33:47PM +0000, Srinivas Kandagatla wrote:
> This driver reuses pdev->id for spi bus numbers resulting in random
> or very large bus numbering when used with device trees. pdev->id
> is not the correct choice when using device trees. So add code to
What makes you say this, why is pdev->id not "correct"? It is worrying
if anything cares what number we pick.
> get bus numbers via device tree aliases and if it fails then generate
> a unique bus number.
The other question is even if this is a good idea why is it something
that should be open coded in individual drivers, if we want to change
the policy we should be consistent between drivers.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-01-21 18:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 18:33 Srinivas Kandagatla
2016-01-21 18:38 ` Mark Brown [this message]
2016-01-21 18:47 ` Srinivas Kandagatla
2016-01-21 19:03 ` Mark Brown
2016-01-21 19:26 ` Srinivas Kandagatla
2016-01-21 20:14 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160121183810.GN6588@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®