From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753269AbcAUVF4 (ORCPT ); Thu, 21 Jan 2016 16:05:56 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:50671 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752719AbcAUVFv (ORCPT ); Thu, 21 Jan 2016 16:05:51 -0500 Date: Thu, 21 Jan 2016 13:05:43 -0800 From: Shaohua Li To: Vivek Goyal CC: , , , , , Subject: Re: [RFC 3/3] blk-throttling: detect inactive cgroup Message-ID: <20160121210542.GB3696942@devbig084.prn1.facebook.com> References: <6311e9d0e215083504a082b200ef4da020ca7c68.1453308862.git.shli@fb.com> <20160121204405.GE8379@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160121204405.GE8379@redhat.com> User-Agent: Mutt/1.5.20 (2009-12-10) X-Originating-IP: [192.168.52.123] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-01-21_07:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 21, 2016 at 03:44:05PM -0500, Vivek Goyal wrote: > On Wed, Jan 20, 2016 at 09:49:19AM -0800, Shaohua Li wrote: > > If a cgroup is inactive for some time, it should be excluded from > > bandwidth calculation. > > I am not sure why do we require this patch. If group is inactive, it > will not be on service tree and will not contribute to weight hence > will not contrinute to share. The share calculation is based on existing cgroups (with this patch, existing active cgroups). a cgroup is on service tree when it has pending bios, right? Not having pending bios isn't a condition we should exclude a cgroup. Thanks, Shaohua