From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753013AbcAVKKN (ORCPT ); Fri, 22 Jan 2016 05:10:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50593 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752389AbcAVKKG (ORCPT ); Fri, 22 Jan 2016 05:10:06 -0500 Date: Fri, 22 Jan 2016 11:10:03 +0100 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org, eranian@google.com, Michael Petlan Subject: Re: perf, tools: Refactor and support interval and CSV metrics Message-ID: <20160122101003.GE11995@krava.brq.redhat.com> References: <1453256812-24006-1-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453256812-24006-1-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 19, 2016 at 06:26:43PM -0800, Andi Kleen wrote: > [v5: Fix mainly bisect problems. No regressions introduced by one > patch and fixed again later. Some minor fixes in addition] > [v6: Fix running/noise printing patch.] > [v7: Reorder and merge two patches to avoid a bisect hole where unsupported was > printed as 0] > [v8: Minor fixes for review feedback. See changelog in patches.] > [v9: Fix newline bug. Add support for -A for --metric-only] > > Currently perf stat does not support printing computed metrics for interval (-I xxx) > or CSV (-x,) mode. For example IPC or TSX metrics over time are quite useful to know. > > This patch implements them. The main obstacle was that the > metrics printing was all open coded all over the metrics computation code. > The second patch refactors the metrics printing to work through call backs that > can be more easily changed. This also cleans up the metrics printing significantly. > The indentation is now handled through printf, no more need to manually count spaces. > > Then based on that it implements metrics printing for CSV and interval mode, > and finally a --metric-only mode. > > Example output: > > % perf stat -I1000 -a sleep 1 > # time counts unit events metric multiplex > 1.001301370 12020.049593 task-clock (msec) (100.00%) > 1.001301370 3,952 context-switches # 0.329 K/sec (100.00%) > 1.001301370 69 cpu-migrations # 0.006 K/sec (100.00%) > 1.001301370 76 page-faults # 0.006 K/sec > 1.001301370 386,582,789 cycles # 0.032 GHz (100.00%) > 1.001301370 716,441,544 stalled-cycles-frontend # 185.33% frontend cycles idle (100.00%) > 1.001301370 stalled-cycles-backend > 1.001301370 101,751,678 instructions # 0.26 insn per cycle > 1.001301370 # 7.04 stalled cycles per insn (100.00%) > 1.001301370 20,914,692 branches # 1.740 M/sec (100.00%) > 1.001301370 1,943,630 branch-misses # 9.29% of all branches > > CSV mode > > % perf stat -x, -I1000 -a sleep 1 > 1.000852081,12016.143006,,task-clock > 1.000852081,4457,,context-switches,12015168277,100.00,0.371,K/sec > 1.000852081,50,,cpu-migrations,12014024424,100.00,0.004,K/sec > 1.000852081,76,,page-faults,12013076716,100.00,0.006,K/sec > 1.000852081,515854373,,cycles,12011235336,100.00,0.043,GHz > 1.000852081,1030742150,,stalled-cycles-frontend,12010984057,100.00,199.81,frontend cycles idle > 1.000852081,,,stalled-cycles-backend,0,100.00 > 1.000852081,116782495,,instructions,12011130729,100.00,0.23,insn per cycle > 1.000852081,,,,12011130729,100.00,8.83,stalled cycles per insn > 1.000852081,23748237,,branches,12010745125,100.00,1.976,M/sec > 1.000852081,1976560,,branch-misses,12010501884,100.00,8.32,of all branches > > Available in > git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc-2.6 perf/stat-metrics-13 this looks like great test candidate for the testing suite Michael is working on.. CC-ed thanks, jirka