mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Insu Yun <wuninsu@gmail.com>
Cc: jslaby@suse.com, linux-kernel@vger.kernel.org, taesoo@gatech.edu,
	yeongjin.jang@gatech.edu, insu@gatech.edu, changwoo@gatech.edu
Subject: Re: [PATCH] vt: correctly check return value of class_create
Date: Sat, 23 Jan 2016 15:51:47 -0800	[thread overview]
Message-ID: <20160123235147.GC32511@kroah.com> (raw)
In-Reply-To: <1453582366-23407-1-git-send-email-wuninsu@gmail.com>

On Sat, Jan 23, 2016 at 03:52:46PM -0500, Insu Yun wrote:
> Since class_create can be failed in memory pressure,

In this case, really?  At init time?

> its return value should be checked and correctly handled.

You didn't correctly handle it, you leaked memory and other resources :(

      reply	other threads:[~2016-01-23 23:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-23 20:52 Insu Yun
2016-01-23 23:51 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160123235147.GC32511@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=changwoo@gatech.edu \
    --cc=insu@gatech.edu \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=taesoo@gatech.edu \
    --cc=wuninsu@gmail.com \
    --cc=yeongjin.jang@gatech.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome