From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754828AbcAYGmc (ORCPT ); Mon, 25 Jan 2016 01:42:32 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:43344 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752684AbcAYGma (ORCPT ); Mon, 25 Jan 2016 01:42:30 -0500 Date: Sun, 24 Jan 2016 22:42:22 -0800 (PST) Message-Id: <20160124.224222.1748787418887617295.davem@davemloft.net> To: jarod@redhat.com Cc: linux-kernel@vger.kernel.org, edumazet@google.com, jiri@mellanox.com, daniel@iogearbox.net, tom@herbertland.com, j.vosburgh@gmail.com, vfalico@gmail.com, gospo@cumulusnetworks.com, netdev@vger.kernel.org Subject: Re: [RFC PATCH net] net/core: don't increment rx_dropped on inactive slaves From: David Miller In-Reply-To: <1453489882-57948-1-git-send-email-jarod@redhat.com> References: <1453489882-57948-1-git-send-email-jarod@redhat.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 24 Jan 2016 22:42:24 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jarod Wilson Date: Fri, 22 Jan 2016 14:11:22 -0500 > diff --git a/net/core/dev.c b/net/core/dev.c > index 8cba3d8..1354c7b 100644 > --- a/net/core/dev.c > +++ b/net/core/dev.c > @@ -4153,8 +4153,11 @@ ncls: > else > ret = pt_prev->func(skb, skb->dev, pt_prev, orig_dev); > } else { > + if (deliver_exact) > + goto inactive; /* bond or team inactive slave */ > drop: > atomic_long_inc(&skb->dev->rx_dropped); > +inactive: > kfree_skb(skb); > /* Jamal, now you will not able to escape explaining > * me how you were going to use this. :-) > -- > 1.8.3.1 > I agree that rx_dropped is not the correct stat to bump here, but I'm totally against the event disappearing completely into thin air. You have to replace the rx_dropped bump with _something_. The only reason this hasn't been "fixed" yet is that everyone is too damn lazy to implement that "something".