From: Al Viro <viro@ZenIV.linux.org.uk>
To: Chen Gang <chengang@emindsoft.com.cn>
Cc: dhowells@redhat.com, akpm@linux-foundation.org,
nicolas.iooss_linux@m4x.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fs: dcache: Use bool return value instead of int
Date: Sun, 24 Jan 2016 21:27:29 +0000 [thread overview]
Message-ID: <20160124212728.GA17997@ZenIV.linux.org.uk> (raw)
In-Reply-To: <56A53FEF.6020803@emindsoft.com.cn>
On Mon, Jan 25, 2016 at 05:19:43AM +0800, Chen Gang wrote:
> Hello all:
>
> Is this patch OK? shall I send the other patch based on this one? (the
> other patch is v3 trivial patch for include/linux/dcache.h).
>
> And sorry for replying late: the last week, I was not in Beijing, had to
> be busy for analyzing a Linux kernel usb related issue for my company's
> customer in Guangzhou (but at last, I guess, it is not kernel issue).
Again, do you have _any_ evidence of improved code generation with that
patch? Because if you do, I would really like to see it, so I could file
bugs against gcc optimizer.
Your impression of what _Bool is and what semantics does it have appears
to be rather different from that described in C99, but that's a secondary
issue - first and foremost, on which .config and with which gcc version
do you see improvements from that change?
next prev parent reply other threads:[~2016-01-24 21:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 21:30 chengang
2016-01-11 22:51 ` Al Viro
2016-01-12 21:42 ` Chen Gang
2016-01-12 22:21 ` Al Viro
2016-01-13 22:39 ` Chen Gang
2016-01-13 22:54 ` Al Viro
2016-01-14 15:39 ` Chen Gang
2016-01-24 21:19 ` Chen Gang
2016-01-24 21:27 ` Al Viro [this message]
2016-01-25 21:24 ` Chen Gang
2016-01-12 0:33 ` David Howells
2016-01-12 1:02 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160124212728.GA17997@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=chengang@emindsoft.com.cn \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.iooss_linux@m4x.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome