From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933066AbcAYSxn (ORCPT ); Mon, 25 Jan 2016 13:53:43 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:49173 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757862AbcAYSxY (ORCPT ); Mon, 25 Jan 2016 13:53:24 -0500 Date: Mon, 25 Jan 2016 10:53:23 -0800 (PST) Message-Id: <20160125.105323.453007330881616541.davem@davemloft.net> To: vkuznets@redhat.com Cc: netdev@vger.kernel.org, kys@microsoft.com, haiyangz@microsoft.com, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, eric.dumazet@gmail.com, tom@herbertland.com, gnomes@lxorguk.ukuu.org.uk Subject: Re: [PATCH net-next] hv_netvsc: use skb_get_hash() instead of a homegrown implementation From: David Miller In-Reply-To: <1453734041-20394-1-git-send-email-vkuznets@redhat.com> References: <1453734041-20394-1-git-send-email-vkuznets@redhat.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 25 Jan 2016 10:53:24 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vitaly Kuznetsov Date: Mon, 25 Jan 2016 16:00:41 +0100 > Recent changes to 'struct flow_keys' (e.g commit d34af823ff40 ("net: Add > VLAN ID to flow_keys")) introduced a performance regression in netvsc > driver. Is problem is, however, not the above mentioned commit but the > fact that netvsc_set_hash() function did some assumptions on the struct > flow_keys data layout and this is wrong. > > Get rid of netvsc_set_hash() by switching to skb_get_hash(). This change > will also imply switching to Jenkins hash from the currently used Toeplitz > but it seems there is no good excuse for Toeplitz to stay. > > Signed-off-by: Vitaly Kuznetsov Applied.