From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756228AbcAYK7o (ORCPT ); Mon, 25 Jan 2016 05:59:44 -0500 Received: from mga14.intel.com ([192.55.52.115]:36789 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756057AbcAYK7l (ORCPT ); Mon, 25 Jan 2016 05:59:41 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,344,1449561600"; d="scan'208";a="897758597" Date: Mon, 25 Jan 2016 12:57:31 +0200 From: Mika Westerberg To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org, Lee Jones Subject: Re: [PATCH v1 1/1] mfd: intel-lpss: remove clock tree on error path Message-ID: <20160125105731.GB1790@lahna.fi.intel.com> References: <1453474126-128047-1-git-send-email-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453474126-128047-1-git-send-email-andriy.shevchenko@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 22, 2016 at 04:48:46PM +0200, Andy Shevchenko wrote: > We forgot to remove the clock tree if something goes wrong in ->probe(). Add a > call to intel_lpss_unregister_clock() on error path in ->probe() to fix the > potential issue. > > Fixes: 4b45efe85263 (mfd: Add support for Intel Sunrisepoint LPSS devices) > Signed-off-by: Andy Shevchenko Acked-by: Mika Westerberg