From: Peter Zijlstra <peterz@infradead.org>
To: Huang Rui <ray.huang@amd.com>
Cc: "Borislav Petkov" <bp@suse.de>, "Ingo Molnar" <mingo@kernel.org>,
"Andy Lutomirski" <luto@amacapital.net>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Robert Richter" <rric@kernel.org>,
"Jacob Shin" <jacob.w.shin@gmail.com>,
"John Stultz" <john.stultz@linaro.org>,
"Frédéric Weisbecker" <fweisbec@gmail.com>,
linux-kernel@vger.kernel.org, spg_linux_kernel@amd.com,
x86@kernel.org, "Guenter Roeck" <linux@roeck-us.net>,
"Andreas Herrmann" <herrmann.der.user@googlemail.com>,
"Suravee Suthikulpanit" <suravee.suthikulpanit@amd.com>,
"Aravind Gopalakrishnan" <Aravind.Gopalakrishnan@amd.com>,
"Borislav Petkov" <bp@alien8.de>,
"Fengguang Wu" <fengguang.wu@intel.com>,
"Aaron Lu" <aaron.lu@intel.com>
Subject: Re: [PATCH v3] perf/x86/amd/power: Add AMD accumulated power reporting mechanism
Date: Mon, 25 Jan 2016 12:13:05 +0100 [thread overview]
Message-ID: <20160125111305.GU6357@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1453710723-1616-1-git-send-email-ray.huang@amd.com>
On Mon, Jan 25, 2016 at 04:32:03PM +0800, Huang Rui wrote:
> +struct power_pmu {
> + raw_spinlock_t lock;
> + struct list_head active_list;
Maybe a dumb question, but what is that list for?
You only ever add/del events to/from it, you never iterate it. So why
keep it?
If you drop the list, the lock can go too I think, making all this stuff
simpler.
next prev parent reply other threads:[~2016-01-25 11:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 8:32 Huang Rui
2016-01-25 11:13 ` Peter Zijlstra [this message]
2016-01-25 15:43 ` Huang Rui
2016-01-26 8:28 ` Ingo Molnar
2016-01-26 13:47 ` Huang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160125111305.GU6357@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Aravind.Gopalakrishnan@amd.com \
--cc=aaron.lu@intel.com \
--cc=bp@alien8.de \
--cc=bp@suse.de \
--cc=fengguang.wu@intel.com \
--cc=fweisbec@gmail.com \
--cc=herrmann.der.user@googlemail.com \
--cc=jacob.w.shin@gmail.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=ray.huang@amd.com \
--cc=rric@kernel.org \
--cc=spg_linux_kernel@amd.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome