From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757046AbcAYL0U (ORCPT ); Mon, 25 Jan 2016 06:26:20 -0500 Received: from mail.fireflyinternet.com ([87.106.93.118]:61075 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756549AbcAYL0P (ORCPT ); Mon, 25 Jan 2016 06:26:15 -0500 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Date: Mon, 25 Jan 2016 11:26:08 +0000 From: Chris Wilson To: Andreas Ziegler Cc: Daniel Vetter , Jani Nikula , intel-gfx@lists.freedesktop.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/i915: Remove select to deleted STOP_MACHINE from Kconfig Message-ID: <20160125112608.GF10520@nuc-i3427.alporthouse.com> Mail-Followup-To: Chris Wilson , Andreas Ziegler , Daniel Vetter , Jani Nikula , intel-gfx@lists.freedesktop.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <1453720481-19529-1-git-send-email-andreas.ziegler@fau.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453720481-19529-1-git-send-email-andreas.ziegler@fau.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 25, 2016 at 12:14:41PM +0100, Andreas Ziegler wrote: > Commit 86fffe4a61dd ("kernel: remove stop_machine() Kconfig > dependency") removed the option STOP_MACHINE from init/Kconfig, but > missed a select to this option from the DRM_I915 option. The select didn't exist on the branch on which the patch was applied, so it couldn't remove it. Commit 5bab6f60cb4 ("drm/i915: Serialise updates to GGTT with access through GGTT on Braswel") depended upon a working stop_machine() and so forced its selection. However, commit 86fffe4a61dd ("kernel: remove stop_machine() Kconfig dependency") removed the option STOP_MACHINE from init/Kconfig and ensured that stop_machine() universally works. Remove this now obsolete select statement. > Signed-off-by: Andreas Ziegler With a little bit of story correction, Revieweed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre