From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757076AbcAYLe3 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 25 Jan 2016 06:34:29 -0500
Received: from down.free-electrons.com ([37.187.137.238]:52345 "EHLO
	mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1755727AbcAYLe0 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 25 Jan 2016 06:34:26 -0500
Date: Mon, 25 Jan 2016 12:34:24 +0100
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Lothar =?iso-8859-1?Q?Wa=DFmann?= <LW@KARO-electronics.de>
Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
        Kumar Gala <galak@codeaurora.org>, Mark Rutland <mark.rutland@arm.com>,
        Nicolas Ferre <nicolas.ferre@atmel.com>,
        Pawel Moll <pawel.moll@arm.com>, Rob Herring <robh+dt@kernel.org>,
        Russell King <linux@arm.linux.org.uk>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] ARM: dts: sama5d4: add support for Ka-Ro electronics
 TXA5 modules
Message-ID: <20160125113424.GD4027@piout.net>
References: <1453293337-16078-1-git-send-email-LW@KARO-electronics.de>
 <1453293337-16078-4-git-send-email-LW@KARO-electronics.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1453293337-16078-4-git-send-email-LW@KARO-electronics.de>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On 20/01/2016 at 13:35:37 +0100, Lothar Waßmann wrote :
> diff --git a/arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts b/arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts
> new file mode 100644
> index 0000000..fb4a253
> --- /dev/null
> +++ b/arch/arm/boot/dts/at91-sama5d4-txa5-5010.dts
> @@ -0,0 +1,217 @@
> +/*
> + * at91-sama5d4-txa5.dts - Device Tree file for Ka-Ro electronics TXA5 module
> + *

This file can also be called at91-txa5-5010.dts if you prefer unless you
plan to have multiple variants of the board with different SoCs.

> +/dts-v1/;
> +#include "sama5d4.dtsi"
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/pwm/pwm.h>
> +
> +/ {
> +	model = "Ka-Ro SAMA5D4 TXA5";
> +	compatible = "atmel,sama5d4-txa5", "atmel,sama5d4", "atmel,sama5";
> +

The vendor for sama5d4-txa5 is not atmel, this should be
"karo,sama5d4-txa5".

Don't forget to add that vendor prefix in
Documentation/devicetree/bindings/vendor-prefixes.txt


> +	aliases {
> +		display = &display;
> +		ethernet0 = &macb0;
> +		serial0 = &usart0;
> +		serial1 = &usart1;
> +		serial2 = &usart3;
> +		spi0 = &spi0;
> +	};
> +
> +	clocks {
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges;
> +

Those properties should be removed. You probably based yourself on a dts
for an old kernel.

> +		main_clock: clock@0 {
> +			compatible = "atmel,osc", "fixed-clock";
> +			clock-frequency = <12000000>;
> +		};

This node is useless, I think you can remove the whole clocks groups as
you define slow_xtal and main_xtal later.

> +	display: display {
> +		display-timings {
> +		};
> +	};
> +

Don't you need some timings?


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com