From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756315AbcAYMfw (ORCPT ); Mon, 25 Jan 2016 07:35:52 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:45988 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753830AbcAYMfu (ORCPT ); Mon, 25 Jan 2016 07:35:50 -0500 Date: Mon, 25 Jan 2016 12:35:38 +0000 From: Mark Brown To: John Crispin Cc: Javier Martinez Canillas , Steven Liu , Linux Kernel , Henry Chen , Liam Girdwood , linux-mediatek@lists.infradead.org, Matthias Brugger , Chen Zhong , "linux-arm-kernel@lists.infradead.org" Message-ID: <20160125123538.GO6588@sirena.org.uk> References: <1453718405-40815-1-git-send-email-blogic@openwrt.org> <1453718405-40815-2-git-send-email-blogic@openwrt.org> <56A612E2.1010509@openwrt.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Auu5xDuhtuIUeAQs" Content-Disposition: inline In-Reply-To: <56A612E2.1010509@openwrt.org> X-Cookie: APL hackers do it in the quad. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH V2 2/2] regulator: mt6323: Add support for MT6323 regulator X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Auu5xDuhtuIUeAQs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jan 25, 2016 at 01:19:46PM +0100, John Crispin wrote: > On 25/01/2016 13:11, Javier Martinez Canillas wrote: > > You don't have a .of_match table but according the DT bindings, the > > compatible string "mediatek,mt6323-regulator" should be used so there > > should be a OF match table or the vendor prefix of the compatible > > string won't be used for matching (i.e: fallbacks to the driver .name > > for match). > the driver is probed via drivers/mfd/mt6397-core.c and does not require > the OF match table. It loads fine just like the mt6397 driver. That's fine but you shouldn't have the compatible string in your binding document since it's not actually used or needed. --Auu5xDuhtuIUeAQs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWphaZAAoJECTWi3JdVIfQuXoH/RT0cUoLm0mCg22K3pE/ipB9 L/TgkSJDvTSL1DyeC8BaPmUbcM7OWfFj5V3f8SXCjt2V53PWP2IpZ6RqzM3E3fn0 MVKJeDYAhkupRwff1nk27MiN/T3nmPuvMDteWxjWDC3p2XUpT5k8vUuC/PGp1uLc ghkqH4t+7rkdlfNRogN8eKx+3gJ4YAZIoG9wWSZfMhkXBUyUauxDNTZeqYKpU+wS Kt1ccOWyp4PpxrNv+aOPgAEBJU8nl5dnDWkEwT6fIMGhQw6Ro/VkOFzaDW+SRpfQ a+P6frizDdasaZslctk7p2uAzX83QbiWGyc2PrF6dRr/7lYqTd3hf1U8hPcTQew= =52H9 -----END PGP SIGNATURE----- --Auu5xDuhtuIUeAQs--