From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933379AbcAYQCN (ORCPT ); Mon, 25 Jan 2016 11:02:13 -0500 Received: from mail-pa0-f66.google.com ([209.85.220.66]:34289 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932874AbcAYQCE (ORCPT ); Mon, 25 Jan 2016 11:02:04 -0500 Date: Mon, 25 Jan 2016 21:31:59 +0530 From: Amitoj Kaur Chawla To: swarren@wwwdotorg.org, thierry.reding@gmail.com, gnurou@gmail.com, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Cc: julia.lawall@lip6.fr Subject: [PATCH 1/2] memory: tegra: mc: Add missing of_node_put Message-ID: <20160125160159.GA21563@amitoj-Inspiron-3542> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org for_each_child_of_node performs an of_node_get on each iteration, so to break out of the loop an of_node_put is required. Found using Coccinelle. The semantic patch used for this is as follows: // @@ expression e; local idexpression n; @@ for_each_child_of_node(..., n) { ... when != of_node_put(n) when != e = n ( return n; | + of_node_put(n); ? return ...; ) ... } // --- There is also an extra of_node_put() before a continue in the same loop on line 212 of this file which should be deleted. Julia Lawall has already sent a patch to delete this but if preferred I can send one patch to do both the changes. drivers/memory/tegra/mc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c index a1ae0cc..7dd42e7 100644 --- a/drivers/memory/tegra/mc.c +++ b/drivers/memory/tegra/mc.c @@ -186,8 +186,10 @@ static int load_timings(struct tegra_mc *mc, struct device_node *node) timing = &mc->timings[i++]; err = load_one_timing(mc, timing, child); - if (err) + if (err) { + of_node_put(child); return err; + } } return 0; @@ -212,9 +214,9 @@ static int tegra_mc_setup_timings(struct tegra_mc *mc) } err = load_timings(mc, node); + of_node_put(node); if (err) return err; - of_node_put(node); break; } -- 1.9.1