From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758008AbcAYRJ1 (ORCPT ); Mon, 25 Jan 2016 12:09:27 -0500 Received: from smtp4-g21.free.fr ([212.27.42.4]:54044 "EHLO smtp4-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758000AbcAYRJT (ORCPT ); Mon, 25 Jan 2016 12:09:19 -0500 Date: Mon, 25 Jan 2016 18:09:15 +0100 From: Guillaume Morin To: Jason Baron Cc: Shawn Bohrer , viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, nab@linux-iscsi.org, gregkh@linuxfoundation.org, Guillaume Morin Subject: Re: 3.14 stable regression don't remove from shrink list in select_collect() Message-ID: <20160125170915.GA9198@bender.morinfr.org> Mail-Followup-To: Jason Baron , Shawn Bohrer , viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, nab@linux-iscsi.org, gregkh@linuxfoundation.org, Guillaume Morin References: <20160125160505.GA7834@sbohrermbp13-local.rgmadvisors.com> <56A64C5D.2060104@akamai.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56A64C5D.2060104@akamai.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25 Jan 11:25, Jason Baron wrote: > > On 01/25/2016 11:05 AM, Shawn Bohrer wrote: > > I recently updated some machines to 3.14.58 and they reliably get soft > > lockups. Sometimes the soft lockup recovers and some times it does > > not. I've bisected this on the 3.14 stable branch and arrived at: > > > > c214cb82cdc744225d85899fc138251527f75fff don't remove from shrink > > list in select_collect() > > > > Reverting this commit plus adding back dentry_lru_del() which was > > removed later on top of 3.14.58 resolves the issue for me. I've > > included a patch at the bottom with the revert. > > I ran into this too on 3.14. You can revert these patches as you've done > or backport the upstream fixes mentioned here: > > http://www.spinics.net/lists/stable/msg111544.html I actually messed up the commit ids in that message, the fixed list is here: http://www.spinics.net/lists/stable/msg111553.html -- Guillaume Morin