From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758464AbcAYT3V (ORCPT ); Mon, 25 Jan 2016 14:29:21 -0500 Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:44318 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757291AbcAYT3T (ORCPT ); Mon, 25 Jan 2016 14:29:19 -0500 Date: Mon, 25 Jan 2016 19:28:10 +0000 From: One Thousand Gnomes To: William Breathitt Gray Cc: wim@iguana.be, linux@roeck-us.net, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] watchdog: Add watchdog timer support for the WinSystems EBC-C384 Message-ID: <20160125192810.2487661b@lxorguk.ukuu.org.uk> In-Reply-To: <20160125190942.GA6824@sophia> References: <20160125190942.GA6824@sophia> Organization: Intel Corporation X-Mailer: Claws Mail 3.13.1 (GTK+ 2.24.29; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +static int ebc_c384_wdt_set_timeout(struct watchdog_device *wdev, unsigned t) > +{ > + /* resolution is in minutes for timeouts greater than 255 seconds */ > + if (t > 255) { > + /* truncate second resolution to minute resolution */ > + t /= 60; > + wdev->timeout = t * 60; > + > + /* set watchdog timer for minutes */ > + outb(0x00, CFG_ADDR); If ask for 299 seconds surely I should get 300 not 240 ? (Whether to round off or round up is an interesting question for the middle range - does it go off early or late - I'd have said late but...) > +static int __init ebc_c384_wdt_init(void) > +{ > + int err; > + > + if (!dmi_match(DMI_BOARD_NAME, "EBC-C384 SBC")) > + return -ENODEV; > + Is there no ACPI entry for it ? Alan