From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756508AbcAZCZR (ORCPT ); Mon, 25 Jan 2016 21:25:17 -0500 Received: from mail-bl2on0071.outbound.protection.outlook.com ([65.55.169.71]:48256 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755711AbcAZCZN (ORCPT ); Mon, 25 Jan 2016 21:25:13 -0500 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; alien8.de; dkim=none (message not signed) header.d=none;alien8.de; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0O1JG1W-07-4F9-02 X-M-MSG: Date: Tue, 26 Jan 2016 10:25:31 +0800 From: Huang Rui To: Gioh Kim , Guenter Roeck CC: "lm-sensors@lm-sensors.org" , "linux-kernel@vger.kernel.org" , "Borislav Petkov" Subject: Re: [RFC] hwmon: (fam15h_power) Add bit masking for tdp_limit Message-ID: <20160126022531.GA23394@hr-amur2> References: <1453722067-6747-1-git-send-email-gi-oh.kim@profitbricks.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1453722067-6747-1-git-send-email-gi-oh.kim@profitbricks.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(979002)(6009001)(2980300002)(428002)(24454002)(164054003)(243025005)(189002)(199003)(54356999)(15975445007)(106466001)(2950100001)(1096002)(23726003)(1220700001)(77096005)(50986999)(105586002)(76176999)(586003)(5008740100001)(97736004)(33656002)(19580395003)(5001770100001)(1076002)(47776003)(189998001)(101416001)(4001350100001)(19580405001)(2906002)(97756001)(50466002)(87936001)(83506001)(4326007)(33716001)(86362001)(92566002)(46406003)(107986001)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN4PR12MB0852;H:atltwp01.amd.com;FPR:;SPF:None;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN4PR12MB0852;2:k5CPTPlxrWYaK6YsOzzySBk5EIMB3+3Er1GJjpmyFuwEF8fLMsKtDtReA6QHCoDoDhAJnCau4sfvW8dHSELyX6DNMmMe6Fbx5aNi4EZlxRUqrPpsbPjvYh6LD86qjve1WVaoW2nSjOju1nhyxRbWyw==;3:/ioQanKjzbJLGCOeGU688qQkt8AXg+S/eeWZB6/9tewcaFKVE9wdxtfT7aaehdgysnE6E5QW+5CEbdYMhMCdoHo8eCHGTkSjxiT9pKToxY9c5I1XjW4MLiJVyv7EJygXl5jd2HsrmyML8+xtbTpb8iIyWf+FtBRvccsDm8mjAFYEL2DR51jKEr3fOYpgL1cNFcNCExoujHZAUKVg4DsGpBHU7N6rVzMEXxrxjKgEKyQ=;25:OafqqyOFzTPs2U456iRZ0sJkauIS5RuoYrIKHpYkWoRFnGohanI7gmCrqO8rACeB0QLL7L6J3CIl9F+/HmkfVQjpj8ZM5B/xBfxsbDEO2RtVZuNvVbJvFwnU2avtZIZdaBSeplXXY0T5N/7423LKC2m4WWjCq5ihjKZELOaZP4m6aagcwTinvzO/Cfz+Gudeeat7wen0YLgwyjVWUi6Yn6HEdN3e+7JVczwepAwCl0nv3HIaB42d0O/wtWZBsbN+ X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN4PR12MB0852; X-MS-Office365-Filtering-Correlation-Id: dd9820e6-b877-4981-eb37-08d325f7ea1d X-Microsoft-Exchange-Diagnostics: 1;BN4PR12MB0852;20:UhiSqJ9Vn/gaVPcRmf5mlXOOIPOllPBLzrAsL6Qa+mGOX0X42O+e0MZaMVCK2N0Pilv25DrcYABocf9fZRhmg5xyPpl6Zjd15Fh0dcqbMBNdJo5D69s/40FAkAhSEpFJYYiTCdmpKutdKPL23RwuUCbbXa0TyBwZIoYkeqsaAWepjJyyp51UOT4Cv/JZnBfZ5sLHfvz5qOF8aKF0uHaeRVXZCYt3fpNg/BsW8mIZLcarSZuyD0Ngea8LemnLpPfSFszCOuEVSQbzo/YyRA9CVPvPtlV4Fhy85iUjhbXHOqM6+p2ftBSLlCV9tv/jF6/LVVqRj0b2GiGKZ2QSVCEysvt1UcJ95M5iFhwPk+WO7W3ztVqFE+5vq7UPfycJF/afhGJxvtsoGUBjc05E10VVFi2/RXFdl3olWo5plT5o3t28sPXT9UA0sG4OzSk+I7YbenTiBUawFEtUPR14AuL7nq9q+bptXM+AAnGitZE7BhSC79CwjnuOntogxKUNGBGS X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(123027)(601004)(2401047)(8121501046)(520078)(13024025)(13017025)(13023025)(5005006)(13018025)(13015025)(3002001)(10201501046);SRVR:BN4PR12MB0852;BCL:0;PCL:0;RULEID:;SRVR:BN4PR12MB0852; X-Microsoft-Exchange-Diagnostics: 1;BN4PR12MB0852;4:6tIrpqe29EToaKBD2D1rQOiPFnvF0/V/m1t7IVvimCNyx0LkdtCEbW/AONjJGYW+m6ufGOVRxCcCyjNikr29b/3a1xoslZZSsh2j/Q45dGef2Z4XG2OgyCQVYGIuT0eU/hRUPpXvvTHbZaskVYtNSNPs8o0lyYIVB554Ye2spzI3ZcD3tkvdR/PKSRTaXmfcInYVJ2gbcznEBZ49JB+GbgFTee30VqKR12Htq4KTDkXKjPYQR30CKf2uT/glKN9K2aqcbaL5fLxn49tqUfY3deSghIOx01ivNvzcepXZsMzi7BjHkIcUf4OLHxdNfBPMPtfMoSZsSEjLDG02W9naxfy/KMJhReH0ACI/BRayZBm6DCuuqUYVAy+PyEgd6DBULW8AHt2ec+TqUzbV3zCJ5IS8mI4Aq7ulPR7itgPHXdSlIrKRVLDYm3kmiHiUsk9OEKwIvKPPM2gL8NTDR0/Myt968iucwer1G48qzPPYc5gE2xu47lFNZ5PlcXVgFGeNzGceyJ9oFg8QRZd/5/rc6g== X-Forefront-PRVS: 08331F819E X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN4PR12MB0852;23:mBUZaXW1feDqWwvy7hQq4p4TAfCJl773l/2JnXaob?= =?us-ascii?Q?808BKHH8HZmpWMjf5gEmFW0U83ucpjUpOWvSj7F5qQNofbhzgrhSiY+ak/M7?= =?us-ascii?Q?6iQa5OmNzo4Ros3k4O4CbHEmlJEUIkll71jdjcpsW0EADTVucN69fjA4OMDx?= =?us-ascii?Q?Fwh5a9adCD/VjVB/SJ2vX2E2WYlglhVbEcF2NRg6SBjT1KRuwg0X964TAtwj?= =?us-ascii?Q?qRI+ADhxnq2hmzFFeZyiePxdco1hfw1Ws41iH36kh4iZWm+2tgtqEQ8jdXW1?= =?us-ascii?Q?nnujEgPYp+8f7qGfp9idCJSj9VbMrnbLs3cbn3Ukbpz3nmSQUePsi9vZbpWV?= =?us-ascii?Q?LdVt24u5cz+VYSNPpGJRFCbne1nJUAtRfapIRlH76qwXHz6KIXGqOdFqS17a?= =?us-ascii?Q?s7ERDCHMGfWpIQG2Zj5vp640ZUMK+scm2hQb11twn6dSgnvuZ9xJNER6M8vI?= =?us-ascii?Q?f1GjuBTR0oEHJaFwkaZtKl4T2TY7kaSn280FmPto1tXXl3J1GPXMuhf8+9Qw?= =?us-ascii?Q?DGjF6SjgHj8k7NACH/9jkHspaD18cf8v8Hgz+3TvigEjjwz3WAm8SplDZfhg?= =?us-ascii?Q?qNnosK2Qd1kEfZmVMzlzc+bgQThQ36jNZw8ibtayw0hkPaVwPkK1pugbt0Y1?= =?us-ascii?Q?G2TAnp1rUv7yVGRWCvfBFmmcNQo2rJZNwOIbLn2Gw1ECEU+WBkeVluIUs3GP?= =?us-ascii?Q?o/Hgw6zghTgu44hcsd9tqXqPwnNPCYUqKv/bdYD62wG+WbgNM46kYC4llCmb?= =?us-ascii?Q?s/45tYjTKzXncpqRGJ+I5xgepVbJifspZCNu+R+p68KWqb3aCBqneTZ083/T?= =?us-ascii?Q?kf2rwqgosPcfHNqstd6HtqUbcYACtunlx8GjQxSneXXM+t1MuUUyntCeSL6N?= =?us-ascii?Q?ZQHzPHxcdL4OUFDHMx320cKDEbBKejjE/AEUyNEkPzj5NOXTcYeLoQtxg+Ly?= =?us-ascii?Q?yfLfsmGXC48w74Pp5ui774DbX7pwdoNgZLflTly4AdfukCTOmljehw1E1mS9?= =?us-ascii?Q?XqjaeOERYmFqYV6j+cbBgai09exvthUzVxyht5dRKfmq3dkhBFpML2f37j+O?= =?us-ascii?Q?V/vdJol4YozIdClOexPwLwj6fEMVD3pwYTLV2j+ns7dZySJisMhM9e96VyOj?= =?us-ascii?Q?jdDBA2t0+GvtMwRDkkv5P4cYY5rIIA3ROcfZiYsQd9VnjL/tiEfTrYXthtn9?= =?us-ascii?Q?1zb4Ejo8Ug3m/HJ3GIa37J0Wmg0EKZGht11?= X-Microsoft-Exchange-Diagnostics: 1;BN4PR12MB0852;5:rqgM3jn+MTbAjBe3h+Ie+P+XsHJG46WG98B5i1clJ+S3kP5sa7eDCvUdjnXVgm4L1D4kKJtOwlY4o9NSOLhbABDdnxaOfSmAEUf86LVxsODzUrwUbIJwS6d1fL0IybHKkn2me77If7w22S1BMHG1qQ==;24:DuiazKjyxJi7E5bb1OB0fFaAzxgrRjySesCkOSUgCeIapz1vkSucB/s0Xl3bssU0lAplNe8dqJJUipCzV56r65AMSWIQE+wNtD+1iDktAm4=;20:LTduF9T6mR/aMN54Nd9y76QkHkXh8cqX9vPq7uNbohO9gOzDnb2PGMif7hLAYv1pchYv0VEOjUIz9oCxG7PlmCe6czGDWjAjnbxAZTBy2TFNexmYRLztBXTz+hozQbNIXlBZO1wpt2U0v6qL2Tn0NJaNIXB9fhnJCvDHJ6uUN28TqfXMPQFg86V86wng2VXyuM5wbLc7DD2v+2FbTQ7h8YLnM8TaSCOKp7VF3vxhCfpDIbjlnLVt6kV5R6W5hlNe SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2016 02:25:09.9472 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.221];Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR12MB0852 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 25, 2016 at 07:41:07PM +0800, Gioh Kim wrote: > The bits [31:29] of D18F5xE8 TDP Limit3 are reserved. > I think it'd better to add masking to read ApmTdpLimit[28:16] precisely. > > Signed-off-by: Gioh Kim > --- > drivers/hwmon/fam15h_power.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwmon/fam15h_power.c b/drivers/hwmon/fam15h_power.c > index f77eb97..f9647c8 100644 > --- a/drivers/hwmon/fam15h_power.c > +++ b/drivers/hwmon/fam15h_power.c > @@ -90,7 +90,7 @@ static ssize_t show_power(struct device *dev, > pci_bus_read_config_dword(f4->bus, PCI_DEVFN(PCI_SLOT(f4->devfn), 5), > REG_TDP_LIMIT3, &val); > > - tdp_limit = val >> 16; > + tdp_limit = (val >> 16) & 0x1fff; Thanks to send the patch on fam15h_power driver. :-) In latest AMD (family 15h, Model 60h) processor, ApmTdpLimit field is expanded to [32:16]. The orignal reserved bits actually are reserved for ApmTdpLimit expansion. http://support.amd.com/TechDocs/50742_15h_Models_60h-6Fh_BKDG.pdf Guenter, Will I collect all patches of fam15h_power and send them to you, or ack it that you can apply directly? Thanks, Rui