mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Mel Gorman <mgorman@techsingularity.net>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Matt Fleming <matt@codeblueprint.co.uk>,
	Mike Galbraith <mgalbraith@suse.de>,
	LKML <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] sched: Make schedstats a runtime tunable that is disabled by default
Date: Tue, 26 Jan 2016 09:13:35 +0100	[thread overview]
Message-ID: <20160126081335.GA8534@gmail.com> (raw)
In-Reply-To: <20160125204518.GK3162@techsingularity.net>


* Mel Gorman <mgorman@techsingularity.net> wrote:

> -	ttwu_stat(p, smp_processor_id(), 0);
> +	if (schedstat_enabled())
> +		ttwu_stat(p, smp_processor_id(), 0);

Yeah. I actually like this for the cleanup factor as well: your patch makes it a 
_lot_ more obvious what is a statistics slowpath and what is not.

We tried to achieve that effect via the _stat() naming, but in hindsight that was 
a failure.

Thanks,

	Ingo

  reply	other threads:[~2016-01-26  8:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-25 10:05 Mel Gorman
2016-01-25 11:26 ` Peter Zijlstra
2016-01-25 13:39   ` Mel Gorman
2016-01-25 14:59     ` Peter Zijlstra
2016-01-25 15:46       ` Ingo Molnar
2016-01-25 17:07         ` Mel Gorman
2016-01-25 18:40           ` Ingo Molnar
2016-01-25 20:11             ` Mel Gorman
2016-01-25 20:45               ` Mel Gorman
2016-01-26  8:13                 ` Ingo Molnar [this message]
2016-01-25 17:05       ` Mel Gorman
2016-01-25 15:29 ` Matt Fleming
2016-01-25 16:46   ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160126081335.GA8534@gmail.com \
    --to=mingo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@codeblueprint.co.uk \
    --cc=mgalbraith@suse.de \
    --cc=mgorman@techsingularity.net \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome