From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965063AbcAZLhB (ORCPT ); Tue, 26 Jan 2016 06:37:01 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:47082 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932109AbcAZLg7 (ORCPT ); Tue, 26 Jan 2016 06:36:59 -0500 Date: Tue, 26 Jan 2016 11:36:52 +0000 From: Mark Brown To: Johannes Berg Cc: Arnd Bergmann , Simon Arlott , linux-kernel@vger.kernel.org Message-ID: <20160126113652.GC6588@sirena.org.uk> Mail-Followup-To: Johannes Berg , Arnd Bergmann , Simon Arlott , linux-kernel@vger.kernel.org References: <1453759675-28461-1-git-send-email-johannes@sipsolutions.net> <20160125235254.GZ6588@sirena.org.uk> <1453796736.2759.2.camel@sipsolutions.net> <6962431.EnoXCqILtZ@wuerfel> <1453800262.2759.9.camel@sipsolutions.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="S43X/KS965BUmyLu" Content-Disposition: inline In-Reply-To: <1453800262.2759.9.camel@sipsolutions.net> X-Cookie: APL hackers do it in the quad. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] Revert "regmap-mmio: Use native endianness for read/write" X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --S43X/KS965BUmyLu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 26, 2016 at 10:24:22AM +0100, Johannes Berg wrote: > On Tue, 2016-01-26 at 10:09 +0100, Arnd Bergmann wrote: > > However, we have some freedom at the regmap-mmio level, which we can > > sanitize in 4.6 if we want to make it more consistent with the rest > > of regmap. We have around 50 callers of {devm_,}regmap_init_mmio() > > and almost all of them do not specify endianess but expect little- > > endian behavior. We can change all existing instances to set > > REGMAP_ENDIAN_NATIVE explicitly and change regmap_init_mmio() to > > return an error if the caller does not specify a particular endianess > > (big, little, native).=20 > I'm not sure that we can, since regmap also takes the value from the DT > directly, and it seems that a driver passing it would mean the DT value > is no longer honoured? DT should override the value in the driver rather than the other way around. --S43X/KS965BUmyLu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWp1pTAAoJECTWi3JdVIfQ/jIH/2uchSf526tRaCsw2scfcLUu s/uRh/PNfSEDGOHILFCJz0ATvoAowV1yjBZ3F0w6zbt6BJlgTeInR92vidf41DrD 1aeV3q5Cr4UJ4cLjj/mTEP9PPz/osl6aXHnuDQsp7q1tovhBitYCatn9cvILLSrS rWrUeuHYWqErwqbINt2qbnwKiOcPmWV+ge6Zd6uvgmkFnZrfAtFwfGQetEmksTiY q4FFde7rc9HhuTp8UXrHv8I5i0fEOCWp+IF8Vv35r5mFy4NYxr+BYcv6FrJ1kUDb Ug71Kc1R+dTDAvUpUwWCh+VDmwpX1gtqmfCOfkGWKE0oUQ8VfWWuUN4erjcByhk= =nLNp -----END PGP SIGNATURE----- --S43X/KS965BUmyLu--