From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934252AbcAZMdO (ORCPT ); Tue, 26 Jan 2016 07:33:14 -0500 Received: from mail-pa0-f68.google.com ([209.85.220.68]:35362 "EHLO mail-pa0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755079AbcAZMdL (ORCPT ); Tue, 26 Jan 2016 07:33:11 -0500 Date: Tue, 26 Jan 2016 21:32:08 +0900 From: Namhyung Kim To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , Andi Kleen , David Ahern , Frederic Weisbecker , Wang Nan Subject: Re: [PATCH 07/12] perf hists browser: Fix callchain_node__count_rows() Message-ID: <20160126123208.GA24496@danjae.kornet> References: <1453643615-1616-1-git-send-email-namhyung@kernel.org> <1453643615-1616-8-git-send-email-namhyung@kernel.org> <20160126114638.GA15821@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160126114638.GA15821@krava.brq.redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jiri, On Tue, Jan 26, 2016 at 12:46:38PM +0100, Jiri Olsa wrote: > On Sun, Jan 24, 2016 at 10:53:30PM +0900, Namhyung Kim wrote: > > Like other functions, it should stop counting if there's any folded > > callchain. Because of this it occasionally lose the cursor at the end. > > are you reffering to the case when the browser wouldn't jump > to the last entry, but the cursor disappears instead, and then > shows up after holding 'UP' arrow? Right. Since it counts some of folded callchain nodes, the cursor went beyond the end so nothing was shown for them. > > because I've seen that occasionaly ;-) Me too. Thanks, Namhyung