From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753397AbcAZWv5 (ORCPT ); Tue, 26 Jan 2016 17:51:57 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:33119 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751412AbcAZWvz (ORCPT ); Tue, 26 Jan 2016 17:51:55 -0500 Date: Tue, 26 Jan 2016 14:51:53 -0800 From: Andrew Morton To: Dan Williams Cc: Rik van Riel , linux-nvdimm , Dave Hansen , "linux-kernel@vger.kernel.org" , Christoph Hellwig , Linux MM , Ingo Molnar , Mel Gorman , "H. Peter Anvin" , Jerome Glisse , Sudip Mukherjee Subject: Re: [RFC PATCH] mm: support CONFIG_ZONE_DEVICE + CONFIG_ZONE_DMA Message-Id: <20160126145153.44e4f38b04200209d133c0a3@linux-foundation.org> In-Reply-To: References: <20160126000639.358.89668.stgit@dwillia2-desk3.amr.corp.intel.com> <20160126141152.e1043d14502dcca17813afb3@linux-foundation.org> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Jan 2016 14:33:48 -0800 Dan Williams wrote: > >> Towards this end, alias ZONE_DMA and ZONE_DEVICE to work around needing > >> to maintain a unique zone number for ZONE_DEVICE. Record the geometry > >> of ZONE_DMA at init (->init_spanned_pages) and use that information in > >> is_zone_device_page() to differentiate pages allocated via > >> devm_memremap_pages() vs true ZONE_DMA pages. Otherwise, use the > >> simpler definition of is_zone_device_page() when ZONE_DMA is turned off. > >> > >> Note that this also teaches the memory hot remove path that the zone may > >> not have sections for all pfn spans (->zone_dyn_start_pfn). > >> > >> A user visible implication of this change is potentially an unexpectedly > >> high "spanned" value in /proc/zoneinfo for the DMA zone. > > > > Well, all these icky tricks are to avoid increasing ZONES_SHIFT, yes? > > Is it possible to just use ZONES_SHIFT=3? > > Last I tried I hit this warning in mm/memory.c > > #warning Unfortunate NUMA and NUMA Balancing config, growing > page-frame for last_cpupid. Well yes, it may take a bit of work - perhaps salvaging a bit from somewhere else if poss. But that might provide a better overall solution so could you please have a think?