From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934748AbcAZPzX (ORCPT ); Tue, 26 Jan 2016 10:55:23 -0500 Received: from mail-pf0-f196.google.com ([209.85.192.196]:34013 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932190AbcAZPzV (ORCPT ); Tue, 26 Jan 2016 10:55:21 -0500 Date: Wed, 27 Jan 2016 00:54:17 +0900 From: Namhyung Kim To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , Andi Kleen , David Ahern , Frederic Weisbecker , Wang Nan Subject: Re: [PATCHSET 00/12] perf tools: Apply percent-limit to callchains Message-ID: <20160126155417.GC6506@danjae.kornet> References: <1453643615-1616-1-git-send-email-namhyung@kernel.org> <20160126121447.GA19017@krava.brq.redhat.com> <20160126125159.GB24496@danjae.kornet> <20160126132726.GA21547@krava.brq.redhat.com> <20160126141025.GA6506@danjae.kornet> <20160126144135.GB24661@krava.brq.redhat.com> <20160126144907.GB6506@danjae.kornet> <20160126151800.GA25977@krava.brq.redhat.com> <20160126153035.GG4361@kernel.org> <20160126154116.GA26800@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160126154116.GA26800@krava.brq.redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 26, 2016 at 04:41:16PM +0100, Jiri Olsa wrote: > On Tue, Jan 26, 2016 at 12:30:36PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Jan 26, 2016 at 04:18:00PM +0100, Jiri Olsa escreveu: > > > On Tue, Jan 26, 2016 at 11:49:07PM +0900, Namhyung Kim wrote: > > > > > > SNIP > > > > > > > > __hrtimer_run_queues > > > > > tick_sched_timer > > > > > tick_sched_handle.isra.17 > > > > > update_process_times > > > > > scheduler_tick > > > > > perf_event_task_tick > > > > > perf_pmu_enable.part.87 > > > > > x86_pmu_enable > > > > > intel_pmu_enable_all > > > > > intel_bts_enable_local > > > > > > > > > > 0.08% 0.00% perf [kernel.vmlinux] [k] perf_pmu_enable.part.87 > > > > > 0.08% 0.00% perf [kernel.vmlinux] [k] perf_event_context_sched_in > > > > > 0.08% 0.00% perf [kernel.vmlinux] [k] perf_event_exec > > > > > 0.08% 0.00% perf [kernel.vmlinux] [k] setup_new_exec > > > > > 0.08% 0.00% perf [kernel.vmlinux] [k] load_elf_binary > > > > > 0.08% 0.00% perf [kernel.vmlinux] [k] search_binary_handler > > > > > 0.08% 0.00% perf [kernel.vmlinux] [k] do_execveat_common.isra.33 > > > > > 0.08% 0.00% perf [kernel.vmlinux] [k] sys_execve > > > > > 0.08% 0.00% perf [kernel.vmlinux] [k] return_from_execve > > > > > 0.08% 0.00% perf [unknown] [k] 0x00007f2175b35e07 > > > > > 0.04% 0.00% perf [kernel.vmlinux] [k] perf_event_nmi_handler > > > > > 0.04% 0.00% perf [kernel.vmlinux] [k] nmi_handle > > > > > 0.04% 0.00% perf [kernel.vmlinux] [k] default_do_nmi > > > > > 0.04% 0.00% perf [kernel.vmlinux] [k] do_nmi > > > > > 0.04% 0.00% perf [kernel.vmlinux] [k] end_repeat_nmi > > > > > 0.04% 0.04% perf [kernel.vmlinux] [k] x86_pmu_enable > > > > > 0.04% 0.04% perf [kernel.vmlinux] [k] native_apic_mem_write > > > > > > > > > > > > > What's the problem? Now by default callchains under 0.5% (absolute) > > > > will not be shown. I think this is intended output, and we need to > > > > consider changing the default percent limit. > > > > > > hm, just the TUI shows +- for entries with no callchain > > > > Humm, this is an old bug, never got around to try to fix it, or is this > > something you were not experiencing before this patchkit from Namhyung? > > > > well, there were callchains present before this patchset ;-) That is because we apply percent limit to callchains now, and the default is 0.5%. Before this patchset percent limit seems not applied so you saw the callchains under the limit. Thanks, Namhyung