From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752784AbcA0BUG (ORCPT ); Tue, 26 Jan 2016 20:20:06 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:48422 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751008AbcA0BUA (ORCPT ); Tue, 26 Jan 2016 20:20:00 -0500 X-AuditID: cbfee690-f79646d000001316-49-56a81b3e3f90 Date: Wed, 27 Jan 2016 10:19:57 +0900 From: Andi Shyti To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Kukjin Kim , rtc-linux@googlegroups.com, Chanwoo Choi , Alexandre Belloni , Krzysztof Kozlowski , Laxman Dewangan , linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v3 01/10] rtc: max77686: Fix max77686_rtc_read_alarm() return value Message-id: <20160127011957.GA14296@samsunx.samsung> References: <1453836020-29579-1-git-send-email-javier@osg.samsung.com> <1453836020-29579-2-git-send-email-javier@osg.samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-disposition: inline In-reply-to: <1453836020-29579-2-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKIsWRmVeSWpSXmKPExsWyRsSkUNdOekWYwYoLrBYd1xYzWVz/8pzV 4s3bNUwWr18YWvQ/fs1ssXTfahaLy7vmsFnMOL+PyWJ/ZwejA6fHk00XGT32TDzJ5rFpVSeb R2/zOzaPLf132T36tqxi9Pi8SS6APYrLJiU1J7MstUjfLoEro/HnYraCHdwVM77OY25g3M3Z xcjBISFgIrGhRbiLkRPIFJO4cG89WxcjF4eQwApGiZXnrrJCJEwk2g58gkrMYpRoenSFGSQh JPCRUaJvqzSIzSKgKrGj7yBYA5uApkTT7R9sILaIgKnEr7UvWEGamQX2Mkk0vrrDApIQFoiU uN22gQnE5gXasOpJOzvEhmZGiavtj5khEoISPybfA2tgFtCSWL/zOBOELS3x6O8MdpAXOAXc JV4esQcxRQVUJF4drAcZIyHwkV3iw4mrjBDHCUh8m3yIBeJjWYlNB5ghHpOUOLjiBssERrFZ SJbNQrJsFpJlCxiZVzGKphYkFxQnpReZ6BUn5haX5qXrJefnbmIExubpf88m7GC8d8D6EKMA B6MSD++N/cvDhFgTy4orcw8xmgJdMZFZSjQ5H5gA8kriDY3NjCxMTUyNjcwtzZTEeV9L/QwW EkhPLEnNTk0tSC2KLyrNSS0+xMjEwSnVwLj0qNw5xxf9Ww2PSr5wrmu6OOMn0+Vlf9rOXd3E 96elqm2GhPRU/RvPGE9xZ89o3/fz8KTDf2/3JrB/Z921d1tQE7dbv9zn0u0HjP8YfFs1v9B3 V7Bo7vZ/PdIz+rwOGPSz2cqbbufdNW1Cl69LHOscv6Z9GsrZrecuPvsSbePxtfqI0cM9+SlK LMUZiYZazEXFiQAU4fqqyAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42I5/e+xoK6d9IowgzOcFh3XFjNZXP/ynNXi zds1TBavXxha9D9+zWyxdN9qFovLu+awWcw4v4/JYn9nB6MDp8eTTRcZPfZMPMnmsWlVJ5tH b/M7No8t/XfZPfq2rGL0+LxJLoA9qoHRJiM1MSW1SCE1Lzk/JTMv3VbJOzjeOd7UzMBQ19DS wlxJIS8xN9VWycUnQNctMwfoMiWFssScUqBQQGJxsZK+HaYJoSFuuhYwjRG6viFBcD1GBmgg YQ1jRuPPxWwFO7grZnydx9zAuJuzi5GTQ0LARKLtwCc2CFtM4sK99UA2F4eQwCxGiaZHV5hB EkICHxkl+rZKg9gsAqoSO/oOsoLYbAKaEk23f4A1iwiYSvxa+4IVpJlZYC+TROOrOywgCWGB SInbbRuYQGxeoG2rnrSzQ2xoZpS42v6YGSIhKPFj8j2wBmYBLYn1O48zQdjSEo/+zgBq4ODg FHCXeHnEHsQUFVCReHWwfgIj0JUIzbOQNM9C0ryAkXkVo0RqQXJBcVJ6rmFearlecWJucWle ul5yfu4mRnD8P5PawXhwl/shRgEORiUe3hv7l4cJsSaWFVfmHmKU4GBWEuFNZlgRJsSbklhZ lVqUH19UmpNafIjRFBggE5mlRJPzgakpryTe0NjEzMjSyNzQwsjYXEmct/ZSZJiQQHpiSWp2 ampBahFMHxMHp1QDY9uKiIYkgQMvumNWXMn/mt0hfVH10KuwMnvmR1XaYTOdXjcfKio0d1vx a/N60+/HXs/fnKXRukHl26PfTglhf9/bKi9UWWRfG3L5SNAnxw8nW49Ly07hklOMX9S7afvt rxETp5s5XHfd1vb/Wni27/wOy1+sjDvMt/88eO7Oqvtr+U7N+5xztVaJpTgj0VCLuag4EQCu L+WDFQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > The function is always returning zero even in case of failures since > the ret value was not propagated to the callers. Fix the error path. > > Reported-by: Krzysztof Kozlowski > Signed-off-by: Javier Martinez Canillas > Reviewed-by: Krzysztof Kozlowski > Tested-by: Krzysztof Kozlowski > Acked-by: Laxman Dewangan Reviewed-by: Andi Shyti > --- > > Changes in v3: > - Add Krzysztof Kozlowski's Reviewed-by and Tested-by to patch #1. > - Add Laxman Dewangan's Acked-by tag to patch #1. > > Changes in v2: None > > drivers/rtc/rtc-max77686.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c > index 7184a0eda793..6653c3d11b66 100644 > --- a/drivers/rtc/rtc-max77686.c > +++ b/drivers/rtc/rtc-max77686.c > @@ -235,7 +235,7 @@ static int max77686_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm) > > out: > mutex_unlock(&info->lock); > - return 0; > + return ret; > } > > static int max77686_rtc_stop_alarm(struct max77686_rtc_info *info) > -- > 2.5.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html