From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752899AbcA0BVJ (ORCPT ); Tue, 26 Jan 2016 20:21:09 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:54535 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752865AbcA0BVG (ORCPT ); Tue, 26 Jan 2016 20:21:06 -0500 X-AuditID: cbfee68f-f793a6d000001364-e1-56a81b815425 Date: Wed, 27 Jan 2016 10:21:05 +0900 From: Andi Shyti To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Kukjin Kim , rtc-linux@googlegroups.com, Chanwoo Choi , Alexandre Belloni , Krzysztof Kozlowski , Laxman Dewangan , linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v3 03/10] rtc: max77686: Use usleep_range() instead of msleep() Message-id: <20160127012105.GC14296@samsunx.samsung> References: <1453836020-29579-1-git-send-email-javier@osg.samsung.com> <1453836020-29579-4-git-send-email-javier@osg.samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-disposition: inline In-reply-to: <1453836020-29579-4-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrOIsWRmVeSWpSXmKPExsWyRsSkULdRekWYwc2TGhYd1xYzWVz/8pzV 4s3bNUwWr18YWvQ/fs1ssXTfahaLy7vmsFnMOL+PyWJ/ZwejA6fHk00XGT32TDzJ5rFpVSeb R2/zOzaPLf132T36tqxi9Pi8SS6APYrLJiU1J7MstUjfLoEr4/XKfYwFkwUrlt49xtzA+Jm3 i5GTQ0LARGJl20IWCFtM4sK99WxdjFwcQgIrGCVm/e1jgSm6uOoTK4gtJDCLUeLVzUiIoo+M EjPmtYAlWARUJbZ928IEYrMJaEo03f7BBmKLCJhK/Fr7ghWkgVlgL5NE46s7YFOFBUIl1r+d wQxi8wJt+LzwEQvE1GZGiT0rVzJCJAQlfky+B9bALKAlsX7ncSYIW1ri0d8Z7CA2p4C7RMft R0CDODhEBVQkXh2sB5kjIfCRXeLPzIdMENcJSHybfIgFpEZCQFZi0wFmiM8kJQ6uuMEygVFs FpJts5Bsm4Vk2wJG5lWMoqkFyQXFSelFxnrFibnFpXnpesn5uZsYgfF5+t+z/h2Mdw9YH2IU 4GBU4uG9sX95mBBrYllxZe4hRlOgKyYyS4km5wOTQF5JvKGxmZGFqYmpsZG5pZmSOO9CqZ/B QgLpiSWp2ampBalF8UWlOanFhxiZODilGhjX8xqpfOpcJjcv5vHq8HXHv60xPn5428KYCiOe GbN21e4WU+EyaMtd187vs2bblbcXb65NyrYNWVioMfNAon2v2yfBBQrWmgs2e9oHKdn1z3rK ZsMnpzxp/uJ7qbOfcm7adUdyXm7PvyyLn1Wilxrmn7cKurQw4HLUcTv/8FjZs5NfTaw3aTug xFKckWioxVxUnAgAwOytYMoCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmphleLIzCtJLcpLzFFi42I5/e+xoG6j9Iowg49blC06ri1msrj+5Tmr xZu3a5gsXr8wtOh//JrZYum+1SwWl3fNYbOYcX4fk8X+zg5GB06PJ5suMnrsmXiSzWPTqk42 j97md2weW/rvsnv0bVnF6PF5k1wAe1QDo01GamJKapFCal5yfkpmXrqtkndwvHO8qZmBoa6h pYW5kkJeYm6qrZKLT4CuW2YO0GlKCmWJOaVAoYDE4mIlfTtME0JD3HQtYBojdH1DguB6jAzQ QMIaxozXK/cxFkwWrFh69xhzA+Nn3i5GTg4JAROJi6s+sULYYhIX7q1nA7GFBGYxSry6GdnF yAVkf2SUmDGvBayIRUBVYtu3LUwgNpuApkTT7R9gDSICphK/1r5gBWlgFtjLJNH46g4LSEJY IFRi/dsZzCA2L9C2zwsfsUBMbWaU2LNyJSNEQlDix+R7YA3MAloS63ceZ4KwpSUe/Z3BDmJz CrhLdNx+BDSIg0NUQEXi1cH6CYxAZyJ0z0LSPQtJ9wJG5lWMEqkFyQXFSem5hnmp5XrFibnF pXnpesn5uZsYwSngmdQOxoO73A8xCnAwKvHw3ti/PEyINbGsuDL3EKMEB7OSCG8yw4owId6U xMqq1KL8+KLSnNTiQ4ymwBCZyCwlmpwPTE95JfGGxiZmRpZG5oYWRsbmSuK8tZciw4QE0hNL UrNTUwtSi2D6mDg4pRoYFf3fLF76r66s9axDcNJOo4gb4V1O+V6qOhpFHSHyP5wXMsw/uEfg 5VLOS5/v8k07vDDravYB6/d+HTsWvOWICahc9/1IWqKMysWJH/+s8zNZz+JZ05/bNyXs3nGp VdwTqqxV9vLvE2aJKJ3n03uotSeze91qy8g9/GsjlzG6M3I2KZldXflQiaU4I9FQi7moOBEA Pt0ujxcDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 26, 2016 at 04:20:13PM -0300, Javier Martinez Canillas wrote: > Documentation/timers/timers-howto.txt suggest to use usleep_range() > instead of msleep() for small msec (1ms - 20ms) since msleep() will > often sleep for 20ms for any value in that range. > > This is fine in this case since 16ms is the _minimum_ delay required > by max77686 for an RTC update but by using usleep_range() instead of > msleep(), the driver can support other RTC IP blocks with a shorter > minimum delay (i.e: in the range of usecs instead of msecs). > > Signed-off-by: Javier Martinez Canillas > Reviewed-by: Krzysztof Kozlowski > Tested-by: Krzysztof Kozlowski Reviewed-by: Andi Shyti > --- > > Changes in v3: > - Add Krzysztof Kozlowski's Tested-by tag to patch #3. > - Add Laxman Dewangan's Acked-by tag to patch #3. > > Changes in v2: > - Add Krzysztof Kozlowski's Reviewed-by tag to patch #3. > - Fix typo error in changelog. Suggested by Krzysztof Kozlowski. > > drivers/rtc/rtc-max77686.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c > index d84a50c9f7f7..025a17a95da3 100644 > --- a/drivers/rtc/rtc-max77686.c > +++ b/drivers/rtc/rtc-max77686.c > @@ -41,7 +41,7 @@ > #define ALARM_ENABLE_SHIFT 7 > #define ALARM_ENABLE_MASK (1 << ALARM_ENABLE_SHIFT) > > -#define MAX77686_RTC_UPDATE_DELAY 16 > +#define MAX77686_RTC_UPDATE_DELAY 16000 > > enum { > RTC_SEC = 0, > @@ -130,7 +130,8 @@ static int max77686_rtc_update(struct max77686_rtc_info *info, > __func__, ret, data); > else { > /* Minimum 16ms delay required before RTC update. */ > - msleep(MAX77686_RTC_UPDATE_DELAY); > + usleep_range(MAX77686_RTC_UPDATE_DELAY, > + MAX77686_RTC_UPDATE_DELAY * 2); > } > > return ret; > -- > 2.5.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html