From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751905AbcA0CM1 (ORCPT ); Tue, 26 Jan 2016 21:12:27 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:32820 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751141AbcA0CMX (ORCPT ); Tue, 26 Jan 2016 21:12:23 -0500 X-AuditID: cbfee68d-f79646d000001355-14-56a827842618 Date: Wed, 27 Jan 2016 11:12:14 +0900 From: Andi Shyti To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Kukjin Kim , rtc-linux@googlegroups.com, Chanwoo Choi , Alexandre Belloni , Krzysztof Kozlowski , Laxman Dewangan , linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v3 07/10] rtc: max77686: Use dev_warn() instead of pr_warn() Message-id: <20160127021214.GG14296@samsunx.samsung> References: <1453836020-29579-1-git-send-email-javier@osg.samsung.com> <1453836020-29579-8-git-send-email-javier@osg.samsung.com> <20160127012230.GE14296@samsunx.samsung> <56A82331.5050403@osg.samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-disposition: inline In-reply-to: <56A82331.5050403@osg.samsung.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrGIsWRmVeSWpSXmKPExsWyRsSkWLdVfUWYQd9tRouOa4uZLK5/ec5q 8ebtGiaL1y8MLfofv2a2WLpvNYvF5V1z2CxmnN/HZLG/s4PRgdPjyaaLjB57Jp5k89i0qpPN o7f5HZvHlv677B59W1YxenzeJBfAHsVlk5Kak1mWWqRvl8CVce3/I9aC/ywVHz+8YWtgvMfc xcjJISFgInH861kmCFtM4sK99WxdjFwcQgIrGCU29j9h7WLkACva/UccIj6LUWLW09vMEM5H Rok/N0+xgHSzCKhKPOrsA5vKJqAp0XT7BxuILSJgKvFr7QtWkAZmgb1MEo2v7oA1CAsESKz7 cJoRxOYF2tD9opMVYupFRolny9ewQyQEJX5MvgfWwCygJbF+53EmCFta4tHfGewg53EK6Etc mmYIYooKqEi8OlgPMkZC4Cu7xM+VP5khjhOQ+Db5EAvEN7ISmw5AfS8pcXDFDZYJjGKzkCyb hWTZLCTLFjAyr2IUTS1ILihOSi8y1CtOzC0uzUvXS87P3cQIjM7T/5717mC8fcD6EKMAB6MS D++N/cvDhFgTy4orcw8xmgJdMZFZSjQ5H5gC8kriDY3NjCxMTUyNjcwtzZTEeRWlfgYLCaQn lqRmp6YWpBbFF5XmpBYfYmTi4JRqYEyJ2hfi9ULk0ot+3viPRsu3rZsqZBbjH7bE811vkGzJ 9CmNOby7S4v+2nwtfP1wwtsHezWC4jeHP33vxXnFZH58xMz31pz93jtDemynKUrun73vzG3/ snu17o+04xIX+Z//9c1gl76YuMcCi/P/BC6kblmZ/GXOX3f5NVX9/kbGitLpty2jryqxFGck GmoxFxUnAgAHRazpyQIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42I5/e+xoG6L+oowg/4tlhYd1xYzWVz/8pzV 4s3bNUwWr18YWvQ/fs1ssXTfahaLy7vmsFnMOL+PyWJ/ZwejA6fHk00XGT32TDzJ5rFpVSeb R2/zOzaPLf132T36tqxi9Pi8SS6APaqB0SYjNTEltUghNS85PyUzL91WyTs43jne1MzAUNfQ 0sJcSSEvMTfVVsnFJ0DXLTMH6DQlhbLEnFKgUEBicbGSvh2mCaEhbroWMI0Rur4hQXA9RgZo IGENY8a1/49YC/6zVHz88IatgfEecxcjB4eEgInE7j/iXYycQKaYxIV769m6GLk4hARmMUrM enqbGcL5yCjx5+YpFpAqFgFViUedfcwgNpuApkTT7R9sILaIgKnEr7UvWEEamAX2Mkk0vroD 1iAsECCx7sNpRhCbF2hb94tOVoipFxklni1fww6REJT4MfkeWAOzgJbE+p3HmSBsaYlHf2ew g5zKKaAvcWmaIYgpKqAi8epg/QRGoDMRmmchaZ6FpHkBI/MqRonUguSC4qT0XKO81HK94sTc 4tK8dL3k/NxNjOAE8Ex6B+PhXe6HGAU4GJV4eG/sXx4mxJpYVlyZe4hRgoNZSYS3R2lFmBBv SmJlVWpRfnxRaU5q8SFGU2CATGSWEk3OByanvJJ4Q2MTMyNLI3NDCyNjcyVx3n2XIsOEBNIT S1KzU1MLUotg+pg4OKUaGJeL1y14ki7AdF/r+tH/07917Za7tPVMTcLBMp86I4mIdUde61yX fnhRwWzz4VmdnpqFa3i3CWesEJz+aNF5q82c56+p/7r88tZrdnbZMy3fGs8ZFG9+++H6jDTh 74F+ZSsXh8zXunGq0knr9v7L/6b1vfaQCeiXvO77et0NjaS1+sX/nW8yhzUqsRRnJBpqMRcV JwIAW8wNPRYDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > >> if (tm->tm_year < 100) { > >>- pr_warn("RTC can't handle year %d. Assume it's 2000.\n", > >>- 1900 + tm->tm_year); > >>+ dev_warn(info->dev, > >>+ "RTC can't handle year %d. Assume it's 2000\n", > >>+ 1900 + tm->tm_year); > >> return -EINVAL; > > > >Because we are returning an error value, why not use dev_err()? > > > > You are absolutely right. Since the driver was using pr_warn(), I used > dev_warn() but dev_err() would had been correct. > > If you don't mind I plan to do it as a follow up patch to avoid having > to resend the whole series only for this change. Fine for me! Andi