From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753901AbcA0GpV (ORCPT ); Wed, 27 Jan 2016 01:45:21 -0500 Received: from mail-bn1on0083.outbound.protection.outlook.com ([157.56.110.83]:53504 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752143AbcA0GpR (ORCPT ); Wed, 27 Jan 2016 01:45:17 -0500 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; alien8.de; dkim=none (message not signed) header.d=none;alien8.de; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0O1LMRB-07-ASM-02 X-M-MSG: Date: Wed, 27 Jan 2016 14:45:38 +0800 From: Huang Rui To: Gi-Oh Kim CC: Guenter Roeck , "lm-sensors@lm-sensors.org" , "linux-kernel@vger.kernel.org" , Borislav Petkov Subject: Re: [RFC] hwmon: (fam15h_power) Add bit masking for tdp_limit Message-ID: <20160127064537.GA25036@hr-amur2> References: <1453722067-6747-1-git-send-email-gi-oh.kim@profitbricks.com> <20160126022531.GA23394@hr-amur2> <56A7511F.1050205@profitbricks.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <56A7511F.1050205@profitbricks.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(189002)(164054003)(24454002)(199003)(57704003)(4326007)(50466002)(19580405001)(83506001)(97756001)(2906002)(86362001)(92566002)(87936001)(3470700001)(46406003)(33716001)(1096002)(77096005)(110136002)(23726003)(11100500001)(54356999)(2950100001)(106466001)(19580395003)(4001350100001)(189998001)(33656002)(97736004)(1076002)(586003)(47776003)(5008740100001)(50986999)(105586002)(76176999)(1220700001)(101416001)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN4PR12MB0852;H:atltwp01.amd.com;FPR:;SPF:None;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN4PR12MB0852;2:X0z9yFU1LSSeR7pniu512jJwjbEvcWbMJVQ6E2iEtszam4pUISFUB5oUJvfzRIFl3Gb1K+H+STU5hOIov94Uda4Lb9IdrFgt9UDGBt1bK/v07B7qS/L2FUHjSwiQit4HhAYpTf0D/vBKhdM5AG0zXA==;3:4eTaduKAHbc1eqdd1KrtsPxyr6ZFrZg8MbPrCEW+OdCp4jz82wIeNHQU1VGnEvxLALHJEKGvfDKBTJTIK/hts4apR+0rNJlFkGRze+SZv0Le8cgPu6XxUMAWt0lmVMWlJcCEuDWuBdbGTKkMhcDHteNIj92he8pduTLHC0E1QhLlbuCqoPghpqgPewZZEoVXPcuimGj8cSSRfqOIGZpoD0p1tBwqn+EWMycU9QmAiDA=;25:g++UcQjCfMdT1SWxxFN4GQC9u250GhfJjuxkp70nh+REvKQY0Bd6b8rgFd12uMkEQihA8PVpiHt/Dh/ww9nbOHSGcOHCR656xpKLSvkimZGN4wkUoxpz7t6lB9AsHcZfBhtO9OfdJd7d5jjuRwoyGj3MWiPSUsAIUWnjr+LosnsK0JMt495FhN5zPmr4yzjqmCXKdmGtjJ02Yo71kSQ5JXRRt7Jmu9WfZOOlkhJQMDn+oc3pVgnZzzXrrZjuPudS X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN4PR12MB0852; X-MS-Office365-Filtering-Correlation-Id: c6ae6a15-1edf-4ac3-90d3-08d326e568c5 X-Microsoft-Exchange-Diagnostics: 1;BN4PR12MB0852;20:Y8l5IVDFK/z6lKBrj9Oldy6jrBGnFB3hWfTV8Jmj+nkwIpnS/1gcYXMlgVd8X9tWFdJa+Oli4uBzYnIaJipmwhY71UMQPq1YOnQ2SbaAKS1Qy6S6HNJ9UmBrLXvT2aokK09voD+x9EqEIgMzQzI9cjSuFjv8NOXwad9a2a1xmE/Tg4A5TnCY02x/qouxO/WBlboZU64n98FePFjmFjwiw7/Hesfy6p168oqWm9AJfS5gbZq37Cui8VkExofawf7UeSpIa+nLLfgUi+zUFOl9SqCsBZuJIG2aCJQEkf+jHhQTxudGUwshwyRWNaT2N0cf0k/f/Geoh8NBuDCwM2IvgQW1JXnb0BDkpK4s9sXNFQpw4ABJReHLpMsNGgw2ckJSUvF3u6wLWIy+qDHTp53dfsWG5Sa4MiODCc7W0JrvSIEoPpPNBaj9GIQV1IyPS2iAnXUMDl3H2YE3AgZkPZQnppX8ttaAC0aDCqvad6teH/SyI9KEY0SSUYaihfjTPAmW X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13024025)(8121501046)(13018025)(13017025)(13023025)(5005006)(13015025)(3002001)(10201501046);SRVR:BN4PR12MB0852;BCL:0;PCL:0;RULEID:;SRVR:BN4PR12MB0852; X-Microsoft-Exchange-Diagnostics: 1;BN4PR12MB0852;4:EBKZ4vZYpA7McL7sSX1qxvVrTSnZcFx3vKZRnFsYscc7c6cuYNjm22CTNacYjGofU5wikZqcc4c/SGAqfzaBNASq38NmPloEQp414NE5FsXD4MIhMLwvScohk6u0/ZRo33HwxbzLobIck4JbOPin8zcL5th++oI2Vb6MFFkR1soZYY8mM9wtjwQtiZTWNKQSuN3j/DL4bjZJSBnH+I9a73aXqn/o79K6B79ZCeobOByf+YJZvYJUDQjwLqYBSNSVfoOq/6cPhALppaEh9xdCqXa2A64A+kefQrudNUdl9ut36dU+n6c8QsPrJsXV+mDecCP51wbahB+KsFAa7Z1h49ujOTFh3i7wj54CaHtraSBbGy7VfD4TUQwac+k2jPt2EEoHYxEf7nHyMoKfvWJPfkuECwk4FHQBNpGizmXnlTHLh8njZKYJzdXVfMqeE6rYyv5/LApaZcH1vak48MnpKg== X-Forefront-PRVS: 0834BAF534 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN4PR12MB0852;23:9hqHNhAY506SGP/L8qitW9kaTtXFzoi5tB8bJrCmB?= =?us-ascii?Q?+mL4CRiHMMa5KtGw+pif+fyrZyvSHKe59XFkJqpmBs4k7n0B82aZ6yTJaPBC?= =?us-ascii?Q?tXaCl1q1UROmbP8w/b95HcTb1wwMwqLaEgY4FAzFDqNJg1q6dIN30IUis+xy?= =?us-ascii?Q?qdmuuthHpBZp2K4Eo+dpfM5mzuf3sZYUWe/bJD7HDd5khIKbGuogLjvFzv9C?= =?us-ascii?Q?jlL+vpOJChy1ixmq9owoE727anm3D/RkkOhl4yCXxy0a0om4tO8dPalzdzTS?= =?us-ascii?Q?81wkg8nPrasi+7sFudmPVtuX+MIZV+fTM+EYo61Gpbj5RcYb8Uny9etOChCb?= =?us-ascii?Q?sj8+bil9RzP2xZEfbiz8sBnBnFY8aClKqdCSiQN4v1AkjzEApHtkntYvaVlR?= =?us-ascii?Q?iWHUKyI95hEanjzlW2OGHfzZ7gKcrcMi2SavbeAxhBo8gIDy6Xm3ix+ceE/O?= =?us-ascii?Q?xqZnJ6ApnqCctIGJT4XcAi61sJJC+GxGhrkM0updFrac1vDJJSSmU9CcDJ23?= =?us-ascii?Q?jYLrg3qZgm2BHfhvJu/cRS+/zRtyun2q9T9c0UqViSxNCaPiTOMv0yj4h9J9?= =?us-ascii?Q?av1TDnu6foYDxC/0rTDGke7TGoKXoh8rh5FL5YKanjvUUgE5ctNH9mVsrfvB?= =?us-ascii?Q?CKCEhWMKKAPlnURKOnwuCqTJI2DC+twwuD3GwcE99SZ14ei3dvgBQjQuNBlV?= =?us-ascii?Q?tLz3ofB0me2niQuQbI3OV9MS5kD/+6jyaymyAgh8l3dLGI7SM+yBFBPLR4k9?= =?us-ascii?Q?a9y3aFMx+eud9OHxkHWbuu0wUwNqX0+rdM/iz6eKkT4R/mdvIOOrN7NIm/kU?= =?us-ascii?Q?8GqBX9SzKUEUQ2A8W3f7p/Oue2MJiOnTLxPg4tFMsHuuXGWs4E3gc9mW9VRm?= =?us-ascii?Q?wWXHPSSsZ5+DauSShDDdtFZOlz2g3t2NY4Qvy8zp4KFRxzy3Sqw7bI0w2kPb?= =?us-ascii?Q?unLKzeqeRnUW4WHIEAo4ujFcOgtujXOOdJSovJMlvZdLwQfF2pcQHBnDoNQy?= =?us-ascii?Q?ZFH+ntmVEfKephB8gFn5QxyHheh8aPojaxA1/SCyUttChqzeRlRs7LRH2dp4?= =?us-ascii?Q?wnGSr/g1S+WqW6nrN7RckoOwbN4DCzWSButk7DSIdOhDqECQAGcJNGgYuVck?= =?us-ascii?Q?ueoafQxhXk=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN4PR12MB0852;5:3ZcRuG74W+lX/EDz5LWa8AEAjMK4HynEA6upsYgnrOaigWjt0MFWAdpYBSC34QHhOoYYk4taeg3e3U8vJZk/OUsbhYG9tLHRswRpnciHU2HGE97Er7rZxqCiG7JJhM1A7hOnwQg8vudhRVbuQWGQeg==;24:DlmoRt150JZfUfErKL92mBh3IIOYGdiqNnGKXkdLP4cSY5WRJcYpefccw62SlJU68kVbY0VbB6hqudlgUKDQjRJdqi34CF/vtp3yMu35AIs=;20:T+5Ip4FiPIXE1YWe/sYrSZJ0spMi9Q8mioJU3nZOELkxyPqrDtxxIhKpBB6ESINDD1JbJsgwrGua7Ymrbh9mXbjIXABHOoaOXBSs2JQ3TgOqVZwv+v+94aM4arg9vfPFAzeN/IemJida61w/QgJYoBik0O0iTr3LEZE6mYWZntffpqNJuhJbzDixp202RbI+UF4KtamyIYKnQzYkbSw6eO0I+VrAYd61jCObmqTKhgw2R6U7pRaCFL0WwvyeLiZH SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2016 06:45:13.1828 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.221];Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR12MB0852 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 26, 2016 at 11:57:35AM +0100, Gi-Oh Kim wrote: > > > On 26.01.2016 03:25, Huang Rui wrote: > >On Mon, Jan 25, 2016 at 07:41:07PM +0800, Gioh Kim wrote: > Thanks for your reply. > I'm not completely sure that the reserved bits are always zero. > Are they always zero? > Or do we need bit-masking like following? > Reserved bits aren't always zero. But here they are reserved for ApmTdpLimit expansion. Yes, we would better add bit-masking here. :-) > -------------- 8< ----------------- > Subject: [PATCH] hwmon: (fam15h_power) Add bit masking for tdp_limit > > Add bit masking to read ApmTdpLimit precisely > > Signed-off-by: Gioh Kim > --- > drivers/hwmon/fam15h_power.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/hwmon/fam15h_power.c b/drivers/hwmon/fam15h_power.c > index f77eb97..edbcf6c 100644 > --- a/drivers/hwmon/fam15h_power.c > +++ b/drivers/hwmon/fam15h_power.c > @@ -90,7 +90,11 @@ static ssize_t show_power(struct device *dev, > pci_bus_read_config_dword(f4->bus, PCI_DEVFN(PCI_SLOT(f4->devfn), 5), > REG_TDP_LIMIT3, &val); > > - tdp_limit = val >> 16; > + if (boot_cpu_data.x86_model >= 0x60) > + tdp_limit = val >> 16; You need add CPU family check and a comment to mention bit field change. This updates since family 15h and model 60h. if (boot_cpu_data.x86 == 0x15 && boot_cpu_data.x86_model >= 0x60) Thanks, Rui