From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S967039AbcA0TqU (ORCPT <rfc822;w@1wt.eu>);
	Wed, 27 Jan 2016 14:46:20 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:59366 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S965107AbcA0TqN (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 27 Jan 2016 14:46:13 -0500
Date: Wed, 27 Jan 2016 11:46:11 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: linux-alpha@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        "linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
        linux-s390@vger.kernel.org, "x86@kernel.org" <x86@kernel.org>,
        "hpa@zytor.com" <hpa@zytor.com>,
        Heiko Carstens <heiko.carstens@de.ibm.com>,
        Richard Henderson <rth@twiddle.net>, Tony Luck <tony.luck@intel.com>,
        Will Deacon <will.deacon@arm.com>, Helge Deller <deller@gmx.de>
Subject: Re: [PATCH v2 resend 6/6] arm64: switch to relative exception
 tables
Message-Id: <20160127114611.25531afcfabf03febc134b48@linux-foundation.org>
In-Reply-To: <CAKv+Gu8hvxcc6Tiu0q7=HWqkEf4ZLfOvyoLGkp2mEgjz_1R9ew@mail.gmail.com>
References: <1453892123-17973-1-git-send-email-ard.biesheuvel@linaro.org>
	<1453892123-17973-7-git-send-email-ard.biesheuvel@linaro.org>
	<20160127113548.d4f2f2a7029b3b89f0e596da@linux-foundation.org>
	<CAKv+Gu8hvxcc6Tiu0q7=HWqkEf4ZLfOvyoLGkp2mEgjz_1R9ew@mail.gmail.com>
X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 27 Jan 2016 20:39:23 +0100 Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:

> On 27 January 2016 at 20:35, Andrew Morton <akpm@linux-foundation.org> wrote:
> > On Wed, 27 Jan 2016 11:55:23 +0100 Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> >
> >> Instead of using absolute addresses for both the exception location
> >> and the fixup, use offsets relative to the exception table entry values.
> >> Not only does this cut the size of the exception table in half, it is
> >> also a prerequisite for KASLR, since absolute exception table entries
> >> are subject to dynamic relocation, which is incompatible with the sorting
> >> of the exception table that occurs at build time.
> >>
> >> This patch also introduces the _ASM_EXTABLE preprocessor macro (which
> >> exists on x86 as well) and its _asm_extable assembly counterpart, as
> >> shorthands to emit exception table entries.
> >
> > checkpatch speaketh truth:
> >
> > ERROR: #define of 'ARCH_HAS_RELATIVE_EXTABLE' is wrong - use Kconfig variables or standard guards instead
> > #113: FILE: arch/arm64/include/asm/uaccess.h:56:
> 
> That may be true, but it extends an established pattern of #defines in
> the various uaccess.h versions, i.e., ARCH_HAS_SORT_EXTABLE, and
> ARCH_HAS_SEARCH_EXTABLE

True.  But now we have two things to fix, not one ;)

Whatever.  Later.