From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933270AbcA0OSH (ORCPT ); Wed, 27 Jan 2016 09:18:07 -0500 Received: from helcar.hengli.com.au ([209.40.204.226]:51132 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932602AbcA0OSE (ORCPT ); Wed, 27 Jan 2016 09:18:04 -0500 Date: Wed, 27 Jan 2016 22:17:46 +0800 From: Herbert Xu To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] crypto: jitterentropy - always select CRYPTO_RNG Message-ID: <20160127141746.GC1601@gondor.apana.org.au> References: <1453815902-3070323-1-git-send-email-arnd@arndb.de> <1453816035-3070440-1-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453816035-3070440-1-git-send-email-arnd@arndb.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 26, 2016 at 02:47:10PM +0100, Arnd Bergmann wrote: > When building the jitterentropy driver by itself, we get a link error > when CRYPTO_RNG is not enabled as well: > > crypto/built-in.o: In function `jent_mod_init': > jitterentropy-kcapi.c:(.init.text+0x98): undefined reference to `crypto_register_rng' > crypto/built-in.o: In function `jent_mod_exit': > jitterentropy-kcapi.c:(.exit.text+0x60): undefined reference to `crypto_unregister_rng' > > This adds a 'select CRYPTO_RNG' to CRYPTO_JITTERENTROPY to ensure the API > is always there when it's used, not just when DRBG is also enabled. > CRYPTO_DRBG would set it implicitly through CRYPTO_JITTERENTROPY now, > but this leaves it in place to make it explicit what the driver does. > > Signed-off-by: Arnd Bergmann Applied. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt