From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933307AbcA0OlV (ORCPT ); Wed, 27 Jan 2016 09:41:21 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:49065 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932494AbcA0OlT (ORCPT ); Wed, 27 Jan 2016 09:41:19 -0500 Date: Wed, 27 Jan 2016 14:41:05 +0000 From: Mark Brown To: John Crispin Cc: Liam Girdwood , Chen Zhong , Matthias Brugger , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Message-ID: <20160127144105.GQ6042@sirena.org.uk> References: <1453896059-44589-1-git-send-email-blogic@openwrt.org> <1453896059-44589-2-git-send-email-blogic@openwrt.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oDto3OTLsk6uOlQH" Content-Disposition: inline In-Reply-To: <1453896059-44589-2-git-send-email-blogic@openwrt.org> X-Cookie: Brain fried -- Core dumped User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323 regulator X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --oDto3OTLsk6uOlQH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 27, 2016 at 01:00:59PM +0100, John Crispin wrote: > + /* Constrain board-specific capabilities according to what > + * this driver and the chip itself can actually do. > + */ > + c =3D rdev->constraints; > + c->valid_modes_mask |=3D REGULATOR_MODE_NORMAL | > + REGULATOR_MODE_STANDBY; > + c->valid_ops_mask |=3D REGULATOR_CHANGE_MODE; No, drivers should *never* enable things that weren't explictly enabled by the machine constraints. This misses the whole point of having constraints. They are there so that the system integrator can enable the functionality that is safe on a given board. =20 The comment is also inaccurate, it claims it's imposing constraints but in fact it's adding additional permissions. --oDto3OTLsk6uOlQH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWqNcAAAoJECTWi3JdVIfQRMQH/jQtT0eQKuCw/Whu0z9TlKYb fVPSsWnDxZnACBT2Pl3Ii8Z5c/AP+JJovpqa33HPGGUA23rdtQWaN4r32fUJFElV akysJGDrq8Mb93XLsjCwRKDWq307j+xH8fX1wbSyHogjvfx0/q61mtWQ+jXdqsCT l66uLPtHPS+sVu4K18jjxQmoh+yv1hDNu2sWO6+Ar5X8IhZ58Dt8qzdFj0yaKhxw kSB0YmsbXnI9TiXFylPafVNTPMAicSZL1+qTVzB+NIAxtRhcLHu6WchGLd2GIjNF QH41GvQMPEEi6WXzXJepV8xizdnbf4jtM2wAYE+Qz9CStsU32eDpArV1rOnZ4mU= =CCQI -----END PGP SIGNATURE----- --oDto3OTLsk6uOlQH--